You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 15:59:22 UTC

[GitHub] [arrow] WillAyd commented on a diff in pull request #12963: ARROW-16234: [C++] Vector Kernel for Rank

WillAyd commented on code in PR #12963:
URL: https://github.com/apache/arrow/pull/12963#discussion_r861064411


##########
cpp/src/arrow/compute/api_vector.h:
##########
@@ -95,6 +95,13 @@ enum class NullPlacement {
   AtEnd,
 };
 
+enum class Tiebreaker {
+  Lowest,

Review Comment:
   Good point. Pandas also uses min / max so should stick with that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org