You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/02/01 10:53:00 UTC

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1011: DISPATCH-1942 Use findPython when on CMake3.12+

jiridanek opened a new pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011


   The newer module can correctly configure build to use Python virtual environment,
   and furthermore the PythonInterp/Libs modules have been deprecated in CMake 3.15


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#discussion_r577753463



##########
File path: CMakeLists.txt
##########
@@ -102,31 +108,29 @@ if (LIBWEBSOCKETS_FOUND AND LIBWEBSOCKETS_VERSION_STRING)
 endif(LIBWEBSOCKETS_FOUND AND LIBWEBSOCKETS_VERSION_STRING)
 
 # Python
-if (PYTHON_VERSION_MAJOR STREQUAL 3)
+if (Python_VERSION_MAJOR STREQUAL 3)
     set(PY_STRING "python3")
-elseif(PYTHON_VERSION_MAJOR STREQUAL 2)
+elseif(Python_VERSION_MAJOR STREQUAL 2)
     set(PY_STRING "python")
 endif()
 
-enable_testing()
-
 # python unittest
 # For versions < 2.7 the developer needs to install the unittest2

Review comment:
       Thanks for the notice. I'll rebase the PR when I'm at a computer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#issuecomment-782737959


   CI issue on Ubuntu is a known crash https://issues.apache.org/jira/browse/DISPATCH-1753 system_tests_policy_oversize_basic timeouted with Error in `qdrouterd': free(): invalid pointer.
   
   MacOS build is already broken on master, currently.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#discussion_r577730677



##########
File path: CMakeLists.txt
##########
@@ -102,31 +108,29 @@ if (LIBWEBSOCKETS_FOUND AND LIBWEBSOCKETS_VERSION_STRING)
 endif(LIBWEBSOCKETS_FOUND AND LIBWEBSOCKETS_VERSION_STRING)
 
 # Python
-if (PYTHON_VERSION_MAJOR STREQUAL 3)
+if (Python_VERSION_MAJOR STREQUAL 3)
     set(PY_STRING "python3")
-elseif(PYTHON_VERSION_MAJOR STREQUAL 2)
+elseif(Python_VERSION_MAJOR STREQUAL 2)
     set(PY_STRING "python")
 endif()
 
-enable_testing()
-
 # python unittest
 # For versions < 2.7 the developer needs to install the unittest2

Review comment:
       We are not doing versions < 2.7 anymore, right? This PR needs to be updated ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#discussion_r578512402



##########
File path: CMakeLists.txt
##########
@@ -102,31 +108,29 @@ if (LIBWEBSOCKETS_FOUND AND LIBWEBSOCKETS_VERSION_STRING)
 endif(LIBWEBSOCKETS_FOUND AND LIBWEBSOCKETS_VERSION_STRING)
 
 # Python
-if (PYTHON_VERSION_MAJOR STREQUAL 3)
+if (Python_VERSION_MAJOR STREQUAL 3)
     set(PY_STRING "python3")
-elseif(PYTHON_VERSION_MAJOR STREQUAL 2)
+elseif(Python_VERSION_MAJOR STREQUAL 2)
     set(PY_STRING "python")
 endif()
 
-enable_testing()
-
 # python unittest
 # For versions < 2.7 the developer needs to install the unittest2

Review comment:
       Rebased.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] codecov-io edited a comment on pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#issuecomment-770911588


   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=h1) Report
   > Merging [#1011](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=desc) (552e04f) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/afc61c816020a8d65f71ec3188e2652b44028a03?el=desc) (afc61c8) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1011      +/-   ##
   ==========================================
   + Coverage   82.46%   82.48%   +0.01%     
   ==========================================
     Files         111      111              
     Lines       27425    27425              
   ==========================================
   + Hits        22617    22622       +5     
   + Misses       4808     4803       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.23% <0.00%> (+0.10%)` | :arrow_up: |
   | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.78% <0.00%> (+0.10%)` | :arrow_up: |
   | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `87.22% <0.00%> (+0.14%)` | :arrow_up: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.06% <0.00%> (+0.21%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=footer). Last update [afc61c8...552e04f](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] codecov-io commented on pull request #1011: DISPATCH-1942 Use findPython when on CMake3.12+

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#issuecomment-770911588


   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=h1) Report
   > Merging [#1011](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=desc) (02fe113) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/0c27fdb9f5016258422f2902f98b27985e31dec9?el=desc) (0c27fdb) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1011      +/-   ##
   ==========================================
   - Coverage   78.95%   78.94%   -0.01%     
   ==========================================
     Files         112      112              
     Lines       28550    28550              
   ==========================================
   - Hits        22542    22540       -2     
   - Misses       6008     6010       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `92.91% <0.00%> (-0.20%)` | :arrow_down: |
   | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.67% <0.00%> (-0.11%)` | :arrow_down: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `91.86% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=footer). Last update [c264665...02fe113](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] codecov-io edited a comment on pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#issuecomment-770911588


   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=h1) Report
   > Merging [#1011](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=desc) (9a1a6e9) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/f07975ee4bde676438d226d885e0eb78937f99b4?el=desc) (f07975e) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1011      +/-   ##
   ==========================================
   - Coverage   82.48%   82.46%   -0.02%     
   ==========================================
     Files         111      111              
     Lines       27425    27425              
   ==========================================
   - Hits        22621    22616       -5     
   - Misses       4804     4809       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `92.02% <0.00%> (-0.44%)` | :arrow_down: |
   | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `92.64% <0.00%> (-0.40%)` | :arrow_down: |
   | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.50% <0.00%> (-0.30%)` | :arrow_down: |
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.03% <0.00%> (-0.11%)` | :arrow_down: |
   | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `87.07% <0.00%> (-0.08%)` | :arrow_down: |
   | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.78% <0.00%> (+0.10%)` | :arrow_up: |
   | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1011/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.69% <0.00%> (+0.57%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=footer). Last update [f07975e...9a1a6e9](https://codecov.io/gh/apache/qpid-dispatch/pull/1011?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek merged pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#issuecomment-778600354


   Made changes to make this look more like https://github.com/apache/qpid-proton/pull/294.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1011: DISPATCH-1942 Use findPython when on CMake3.12+

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#issuecomment-770773504


   The problem with the failing CI here: on GHA Proton finds Python 3.7 and Dispatch now goes for 3.8.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org