[GitHub] [servicecomb-java-chassis] AngLi2 commented on a change in pull request #1329: [SCB-1489] Micro-service instance wouldn't work after we shotdown our service center for updating while we had enable RSA authentication between services.

[GitBox <gi...@apache.org>]

AngLi2 commented on a change in pull request #1329: [SCB-1489] Micro-service instance wouldn't work after we shotdown our service center for updating while we had enable RSA authentication between services.
URL: https://github.com/apache/servicecomb-java-chassis/pull/1329#discussion_r335915112
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceInstance.java
 ##########
 @@ -210,4 +211,8 @@ private static void loadDataCenterInfo(MicroserviceInstance microserviceInstance
       microserviceInstance.setDataCenterInfo(dataCenterInfo);
     }
   }
+
+  public boolean isNil() {
 
 Review comment:
   nil keyword is used in other languages like go, maybe isEmpty, isNull or even isExists is more commonly used in Java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services