You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/09 14:45:55 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition
congbobo184 opened a new pull request #14192:
URL: https://github.com/apache/pulsar/pull/14192
link https://github.com/apache/pulsar/pull/14097
### Motivation
When disable transaction producer connect to broker and the TopicTransactionBuffer is recovering, the TopicTransactionBuffer state is None or Initializing, then send normal message can't change the MaxReadPosition.
If recover success and then producer don't send message to this topic. The maxReadPosition will not be change and consumer will not receive message when the disable transaction producer sent.
### Modifications
1. recover to Ready state, if no ongoing txns, change maxReadPosition to LAC
2. recover to NoSnapshot state, change maxReadPosition to LAC
### Verifying this change
add the test
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14192:
URL: https://github.com/apache/pulsar/pull/14192#issuecomment-1034381476
@eolivelli @nicoloboschi Thanks for the review. I noticed @eolivelli you said you have an integration test that failed due to this issue, after the PR merged I will cherry-pick it into branch-2.9, and could you please help verify again in your integration test? If still have the problem, @congbobo184 can help take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14192:
URL: https://github.com/apache/pulsar/pull/14192#issuecomment-1033840755
@congbobo184:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14192:
URL: https://github.com/apache/pulsar/pull/14192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14192:
URL: https://github.com/apache/pulsar/pull/14192#issuecomment-1033837666
@congbobo184:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14192:
URL: https://github.com/apache/pulsar/pull/14192#issuecomment-1034404082
before approving the PR I've rerun the same integration test @eolivelli was talking about (it was also failing against master) and now it passes correctly @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14192:
URL: https://github.com/apache/pulsar/pull/14192#issuecomment-1034466697
Cool, thanks @nicoloboschi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org