You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/23 01:25:34 UTC
[GitHub] [spark] Yikun opened a new pull request, #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
Yikun opened a new pull request, #38354:
URL: https://github.com/apache/spark/pull/38354
### What changes were proposed in this pull request?
Upgrade actions/setup-java to v3 with distribution specified
### Why are the changes needed?
- The `distribution` is required after v2, now just keep `zulu` (same distribution with v1): https://github.com/actions/setup-java/releases/tag/v2.0.0
- https://github.com/actions/setup-java/releases/tag/v3.0.0: Upgrade node
- https://github.com/actions/setup-java/releases/tag/v3.6.0: Cleanup set-output warning
### Does this PR introduce _any_ user-facing change?
No,dev only
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a diff in pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
Posted by GitBox <gi...@apache.org>.
Yikun commented on code in PR #38354:
URL: https://github.com/apache/spark/pull/38354#discussion_r1002820197
##########
.github/workflows/build_and_test.yml:
##########
@@ -227,8 +227,9 @@ jobs:
restore-keys: |
${{ matrix.java }}-${{ matrix.hadoop }}-coursier-
- name: Install Java ${{ matrix.java }}
- uses: actions/setup-java@v1
+ uses: actions/setup-java@v3
with:
+ distribution: zulu
Review Comment:
Yes, `temurin` is more 'standard', zulu is default used in v1, so I kept it same. But I also think `temurin` no problem. Let's see others idea.
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun closed pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
Posted by GitBox <gi...@apache.org>.
Yikun closed pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
URL: https://github.com/apache/spark/pull/38354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a diff in pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
Posted by GitBox <gi...@apache.org>.
Yikun commented on code in PR #38354:
URL: https://github.com/apache/spark/pull/38354#discussion_r1002820197
##########
.github/workflows/build_and_test.yml:
##########
@@ -227,8 +227,9 @@ jobs:
restore-keys: |
${{ matrix.java }}-${{ matrix.hadoop }}-coursier-
- name: Install Java ${{ matrix.java }}
- uses: actions/setup-java@v1
+ uses: actions/setup-java@v3
with:
+ distribution: zulu
Review Comment:
Yes, `temurin` is more 'standard', zulu is default used in v1, so I kept it same. But I also think `temurin` no problem. Let's see others idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38354:
URL: https://github.com/apache/spark/pull/38354#issuecomment-1288495711
CI passed, will merge soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38354:
URL: https://github.com/apache/spark/pull/38354#discussion_r1002821239
##########
.github/workflows/build_and_test.yml:
##########
@@ -227,8 +227,9 @@ jobs:
restore-keys: |
${{ matrix.java }}-${{ matrix.hadoop }}-coursier-
- name: Install Java ${{ matrix.java }}
- uses: actions/setup-java@v1
+ uses: actions/setup-java@v3
with:
+ distribution: zulu
Review Comment:
Yeah, I think it;s fine to switch to `temurin`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38354:
URL: https://github.com/apache/spark/pull/38354#issuecomment-1288503073
@srowen @HyukjinKwon @LuciferYang Thanks all, merged to master (3.4.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #38354:
URL: https://github.com/apache/spark/pull/38354#discussion_r1002737459
##########
.github/workflows/build_and_test.yml:
##########
@@ -227,8 +227,9 @@ jobs:
restore-keys: |
${{ matrix.java }}-${{ matrix.hadoop }}-coursier-
- name: Install Java ${{ matrix.java }}
- uses: actions/setup-java@v1
+ uses: actions/setup-java@v3
with:
+ distribution: zulu
Review Comment:
Default to temurin maybe? I thought that was the more 'standard' one but I don't know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org