You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "PG1204 (via GitHub)" <gi...@apache.org> on 2026/06/13 18:08:37 UTC
[I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
PG1204 opened a new issue, #5683:
URL: https://github.com/apache/texera/issues/5683
### Task Summary
### Context
`WorkflowEditorComponent.applyOperatorBorder(operatorID)` recomputes validation as its first step:
```typescript
const validation = this.validationWorkflowService.validateOperator(operatorID);
```
When called from the validation-stream subscriber in handleOperatorValidation, this is redundant, the stream's emitted event already carries the Validation result that was just computed in updateValidationState.
Originally flagged as an optional nit during the PR #5146 review. Attempted in PR #5626 but split out per reviewer request so that PR could stay scoped to test restructuring.
### Proposed change
In frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.ts:
- Add an optional validation?: Validation parameter to applyOperatorBorder; use it when provided, fall back to validateOperator(operatorID) otherwise.
- In handleOperatorValidation, pass value.validation from the stream into the helper.
- Operator-add subscription stays unchanged (no Validation in hand -> falls through to the lazy fetch).
### Required test
Add a focused test in workflow-editor.component.spec.ts that asserts validateOperator is not called when a Validation argument is passed in.
### Related
Issue #5318 / PR #5626 (where this was attempted and split out)
### Task Type
- [x] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [ ] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu closed issue #5683: Reuse validation result from the validation stream in applyOperatorBorder
URL: https://github.com/apache/texera/issues/5683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on issue #5683:
URL: https://github.com/apache/texera/issues/5683#issuecomment-4735438343
Hi, I opened PR #5760 to address this issue: https://github.com/apache/texera/pull/5760
The PR reuses the `Validation` emitted by the validation stream in `applyOperatorBorder`, keeps the existing fallback for callers without a validation result, and adds the requested regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on issue #5683:
URL: https://github.com/apache/texera/issues/5683#issuecomment-4735701414
Thanks for pointing that out. I missed #5702 when I picked this up. I’ll close #5760 to avoid duplicating the work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
Posted by "PG1204 (via GitHub)" <gi...@apache.org>.
PG1204 commented on issue #5683:
URL: https://github.com/apache/texera/issues/5683#issuecomment-4735711051
> Thanks for pointing that out. I missed [#5702](https://github.com/apache/texera/pull/5702) when I picked this up. I’ll close [#5760](https://github.com/apache/texera/pull/5760) to avoid duplicating the work.
No worries, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5683:
URL: https://github.com/apache/texera/issues/5683#issuecomment-4699357067
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @PG1204!
It looks like the issue description doesn't quite follow our template yet:
- The **Task Summary** section is empty; please fill it in.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5683:
URL: https://github.com/apache/texera/issues/5683#issuecomment-4699357070
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @PG1204!
It looks like the issue description doesn't quite follow our template yet:
- The **Task Summary** section is empty; please fill it in.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
Posted by "PG1204 (via GitHub)" <gi...@apache.org>.
PG1204 commented on issue #5683:
URL: https://github.com/apache/texera/issues/5683#issuecomment-4699366106
/take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reuse validation result from the validation stream in applyOperatorBorder [texera]
Posted by "PG1204 (via GitHub)" <gi...@apache.org>.
PG1204 commented on issue #5683:
URL: https://github.com/apache/texera/issues/5683#issuecomment-4735623694
> Hi, I opened PR [#5760](https://github.com/apache/texera/pull/5760) to address this issue: [#5760](https://github.com/apache/texera/pull/5760) The PR reuses the `Validation` emitted by the validation stream in `applyOperatorBorder`, keeps the existing fallback for callers without a validation result, and adds the requested regression test.
Hi @kz930 , PR #5702 was raised earlier to close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org