[GitHub] [incubator-nemo] hy00nc commented on a change in pull request #273: [Nemo-429] SWPP TEAM15 Code Smell Fix

[GitBox <gi...@apache.org>]

hy00nc commented on a change in pull request #273: [Nemo-429] SWPP TEAM15 Code Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/273#discussion_r352973771
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/coder/LongDecoderFactory.java
 ##########
 @@ -59,7 +59,7 @@ public String toString() {
    * LongDecoder.
    */
   private final class LongDecoder implements Decoder<Long> {
-    private final DataInputStream inputStream;
+    private final transient DataInputStream inputStream;
 
 Review comment:
   Could you remove the keyword `transient`?  Let's just keep this code as it is so that it will be addressed later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services