You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/09 08:30:03 UTC

[GitHub] [shardingsphere] KoxAlen opened a new pull request #6308: Fixed grammar for MATCH AGAINST expressions

KoxAlen opened a new pull request #6308:
URL: https://github.com/apache/shardingsphere/pull/6308


   Fixes #6299 
   
   Changes proposed in this pull request:
   - Grammar fix.
   - Visit the match expression to keep parameter markers index in sync.
   - Test case.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] KoxAlen edited a comment on pull request #6308: Fixed grammar for MATCH AGAINST expressions

Posted by GitBox <gi...@apache.org>.
KoxAlen edited a comment on pull request #6308:
URL: https://github.com/apache/shardingsphere/pull/6308#issuecomment-656113038


   > BTW, do you mind telling us which feature of Apache ShardingSphere is your choice and how it works in your situation?
   
   We have some tables that can grow very big (a lot of rows), we use ShardingSphere-JDBC to divide them in smaller ones (usually in the same db node but sometimes across different db nodes).
   We use simple sharding rules and so far it has been working well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #6308: Fixed grammar for MATCH AGAINST expressions

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6308:
URL: https://github.com/apache/shardingsphere/pull/6308


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] KoxAlen commented on pull request #6308: Fixed grammar for MATCH AGAINST expressions

Posted by GitBox <gi...@apache.org>.
KoxAlen commented on pull request #6308:
URL: https://github.com/apache/shardingsphere/pull/6308#issuecomment-656113038


   > BTW, do you mind telling us which feature of Apache ShardingSphere is your choice and how it works in your situation?
   
   We have some tables that can grow very big, we use ShardingSphere-JDBC to divide them in smaller ones (usually in the same db node but sometimes across different db nodes).
   We use simple sharding rules and so far it has been working well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #6308: Fixed grammar for MATCH AGAINST expressions

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6308:
URL: https://github.com/apache/shardingsphere/pull/6308#issuecomment-656121840


   @KoxAlen Thanks. I am glad it could provide help for you. ShardingSphere has more interesting features, like data masking. Welcome your attention. 
   
   Best wishes,
   Trista


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #6308: Fixed grammar for MATCH AGAINST expressions

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6308:
URL: https://github.com/apache/shardingsphere/pull/6308#issuecomment-656055746


   Hi @KoxAlen 
   We are glad to receive your prompt feedback. An increased unit test made this PR convinced. :-)
   
   BTW, do you mind telling us which feature of Apache ShardingSphere is your choice and how it works in your situation?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org