You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by pivotal-jbarrett <gi...@git.apache.org> on 2017/02/27 16:15:49 UTC

[GitHub] geode-native pull request #40: GEODE-2552: Remove NanoTimer

GitHub user pivotal-jbarrett opened a pull request:

    https://github.com/apache/geode-native/pull/40

    GEODE-2552: Remove NanoTimer

    Please focus on commits e541e31 ... daf4234, others are artifacts of unpulled requests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pivotal-jbarrett/geode-native feature/GEDOE-2552

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode-native/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit 4f8ee0ba64bae9cbc3fd204e759745236d174d6e
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-16T06:29:09Z

    GEODE-2494: Adds spinlock_mutex.

commit 74efeb5d4ff807720aa051be5765471c64f3d8ea
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-16T06:29:37Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.
    
    - Cleanup C++11 standards.

commit f2ec96e50c974f0f8999b0d7b0ae3e0b2ea64244
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-16T07:33:21Z

    GEODE-2494: Replaced spin lock protected counter with std::atomic.
    
    - Cleanup C++11 standards.

commit ab13aca81d084570d47c090363b5ba92b9ebec3b
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-20T21:42:19Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.

commit 84e5b333d7f53000593d41dcfe7f4011ea823f9f
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-22T05:46:27Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.
    
    - Cleanup C++ standards.

commit 76ca82febc1d68bd1e09b7639c92d59745d626f9
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-22T05:55:33Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.
    
    - Cleanup C++ standards.

commit 46131bea0d787698c124b822d8348b683633c6a2
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-22T06:00:21Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.
    
    - Cleanup C++ standards.

commit 9c8a9d6644a566f2b2d927da6c69a73ece9f5105
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-22T06:14:50Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.
    
    - Cleanup C++ standards.

commit ed88029b45b4b4d5155a76e0b0d0c2c882274581
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-22T06:52:50Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.
    
    - Cleanup C++ standards.

commit 2e2c36b52b48342e59e7f0dac671c59dfb994148
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-23T01:58:05Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.
    
    - Cleanup C++ standards.

commit 8898a1c9b3dc514bd6b8c2630d021a01729d4df8
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-23T03:04:10Z

    GEODE-2494: Replace SpinLock with spinlock_mutex.
    
    - Cleanup C++ standards.

commit ec2e69431c88d00a63b05b3f6fdcec8b970fe780
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-23T05:29:49Z

    GEODE-2494: Removed SpinLock.

commit cf1ba853195e5ecdd63cc5951bd1497e191e1766
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-23T06:38:03Z

    GEODE-2531: Replace HostAsm::atomic with std::atomic.

commit e541e31301c1f6ce9834698fa9e8cdf6dbd025bf
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-25T21:18:12Z

    GEODE-2552: Replace NanoSleep with std::this_thread::sleepFor.
    
    - Replaced custom time/duration with std::crono.

commit 24d74ded53dd262a483d9df8caeb03065727f778
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-25T22:02:58Z

    GEODE-2552: Replaced NanoTimer with std::chrono.

commit 7bb0435089d2ea678a679bb18e9fe85c5eb9ebfe
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-25T22:11:46Z

    GEODE-2552: Replaced NanoTimer with std::chrono.

commit daf423443ca1cc897156bc79089fd4e6deecaeb2
Author: Jacob Barrett <jb...@pivotal.io>
Date:   2017-02-26T23:12:18Z

    GEODE-2552: Removed NanoTimer
    
    - Replaced millisleep with std::this_thread::sleep_for.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #40: GEODE-2552: Remove NanoTimer

Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:

    https://github.com/apache/geode-native/pull/40
  
    @PivotalSarge 
    > Nice fix of the broken window of catching exceptions by value.
    
    If you enable `clang-tidy` you will see plenty of them. I am cleaning up lots of these bad things along the way.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #40: GEODE-2552: Remove NanoTimer

Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:

    https://github.com/apache/geode-native/pull/40
  
    > Would adding const to variables like spentWorking and sleepDuration help the compiler generate more efficient code?
    
    I doubt the compilers would care since it will know the scope is limited to the block and there are no other assignment operations. It does however provide more readable and safe coding style. I could make adjustments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #40: GEODE-2552: Remove NanoTimer

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode-native/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #40: GEODE-2552: Remove NanoTimer

Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:

    https://github.com/apache/geode-native/pull/40
  
    @PivotalSarge 
    > Why the switch to ACE_OS::localtime() from localtime()?
    
    `localtime` AKA POSIX `localtime` is not thread safe. `ACE_OS::localtime` wraps the platform specific `localtime_r` or `localtime_s` functions that are thread safe. Ultimately we want to replace these something like `boost::locale` until something is adopted into the `std`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---