You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "baiyangtx (via GitHub)" <gi...@apache.org> on 2024/05/18 17:20:02 UTC

[PR] [Spark]: Remove useless spark grammar [amoro]

baiyangtx opened a new pull request, #2847:
URL: https://github.com/apache/amoro/pull/2847

    
   
   ## Why are the changes needed?
    
   Grammar of 
   
   ```
   MIGRATE xxx to ARCTIC xxx
   ```
   
   It is logic left over for historical reasons and should not be present in the open source version of amoro code
   
   
   ## Brief change log
    
   - Remove antlr4 files and all of related logic about `MIGRATE xxx TO ARCTIC `
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [X] Run test locally before making a pull request
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Spark]: Remove useless spark grammar MIGRATE commands [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #2847:
URL: https://github.com/apache/amoro/pull/2847


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org