You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/07 11:19:24 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14900: [improvement](vertical_compaction) reduce segments load in vertical merger
github-actions[bot] commented on code in PR #14900:
URL: https://github.com/apache/doris/pull/14900#discussion_r1042082714
##########
be/src/vec/olap/vertical_merge_iterator.h:
##########
@@ -174,6 +174,7 @@ class VerticalMergeIteratorContext {
ref->block = _block;
ref->row_pos = _index_in_block;
}
+ bool inited() { return _inited; }
Review Comment:
warning: method 'inited' can be made const [readability-make-member-function-const]
```suggestion
bool inited() const { return _inited; }
```
##########
be/src/vec/olap/vertical_merge_iterator.cpp:
##########
@@ -529,10 +571,12 @@
// interfaces to create vertical merge iterator
std::shared_ptr<RowwiseIterator> new_vertical_heap_merge_iterator(
- const std::vector<RowwiseIterator*>& inputs, size_t ori_return_cols, KeysType keys_type,
- uint32_t seq_col_idx, RowSourcesBuffer* row_sources) {
- return std::make_shared<VerticalHeapMergeIterator>(std::move(inputs), ori_return_cols,
- keys_type, seq_col_idx, row_sources);
+ const std::vector<RowwiseIterator*>& inputs, const std::vector<bool>& iterator_init_flag,
+ size_t ori_return_cols, KeysType keys_type, uint32_t seq_col_idx,
+ RowSourcesBuffer* row_sources) {
+ return std::make_shared<VerticalHeapMergeIterator>(
+ std::move(inputs), std::move(iterator_init_flag), ori_return_cols, keys_type,
Review Comment:
warning: std::move of the const variable 'iterator_init_flag' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg]
```suggestion
std::move(inputs), iterator_init_flag, ori_return_cols, keys_type,
```
##########
be/src/vec/olap/vertical_merge_iterator.cpp:
##########
@@ -529,10 +571,12 @@ Status VerticalMaskMergeIterator::init(const StorageReadOptions& opts) {
// interfaces to create vertical merge iterator
std::shared_ptr<RowwiseIterator> new_vertical_heap_merge_iterator(
- const std::vector<RowwiseIterator*>& inputs, size_t ori_return_cols, KeysType keys_type,
- uint32_t seq_col_idx, RowSourcesBuffer* row_sources) {
- return std::make_shared<VerticalHeapMergeIterator>(std::move(inputs), ori_return_cols,
- keys_type, seq_col_idx, row_sources);
+ const std::vector<RowwiseIterator*>& inputs, const std::vector<bool>& iterator_init_flag,
+ size_t ori_return_cols, KeysType keys_type, uint32_t seq_col_idx,
+ RowSourcesBuffer* row_sources) {
+ return std::make_shared<VerticalHeapMergeIterator>(
+ std::move(inputs), std::move(iterator_init_flag), ori_return_cols, keys_type,
Review Comment:
warning: std::move of the const variable 'inputs' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg]
```suggestion
inputs, std::move(iterator_init_flag), ori_return_cols, keys_type,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org