[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #456: Support all LTS and one non-LTS Java versions

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #456:
URL: https://github.com/apache/incubator-daffodil/pull/456#discussion_r522393546



##########
File path: daffodil-udf/src/main/java/org/apache/daffodil/udf/UserDefinedFunctionIdentification.java
##########
@@ -28,11 +28,21 @@
  *
  * It must have the name and namespaceURI fields initialized with the namespace
  * and name callers would be expected to use in the schema.
- *
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
 public @interface UserDefinedFunctionIdentification {
+  /**
+   * Get the name of the user defined function
+   *
+   * @return the name of the user defined function
+   */
   String name();
+
+  /**
+   * Get the namespace URI of the user defined function

Review comment:
       I agree, this feels very unnecessary. Javadoc shows up just fine, the only downside is this will output a warning until you add some javadoc. I was trying to minimize the number of warnings so that it's easier to see when we are missing actually important javadoc that we're actually missing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org