You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/05/28 20:19:26 UTC
[GitHub] [lucene] dnhatn opened a new pull request #158: LUCENE-9980: Do not expose deleted commit points in IndexDeletionPolicy
dnhatn opened a new pull request #158:
URL: https://github.com/apache/lucene/pull/158
If we fail to delete files that belong to a commit point, then we will expose that deleted commit in the next calls of `IndexDeletionPolicy#onCommit()`. I think we should never expose those deleted commit points as some of their files might have been deleted already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dnhatn merged pull request #158: LUCENE-9980: Do not expose deleted commit points in IndexDeletionPolicy
Posted by GitBox <gi...@apache.org>.
dnhatn merged pull request #158:
URL: https://github.com/apache/lucene/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dnhatn commented on pull request #158: LUCENE-9980: Do not expose deleted commit points in IndexDeletionPolicy
Posted by GitBox <gi...@apache.org>.
dnhatn commented on pull request #158:
URL: https://github.com/apache/lucene/pull/158#issuecomment-851545808
Thanks Mike for reviewing :).
> Was there an exciting test failure somewhere the lead to this discovery?
Yes, there's a test failure in Elasticsearch: https://github.com/elastic/elasticsearch/issues/39591#issuecomment-655920692.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dnhatn commented on pull request #158: LUCENE-9980: Do not expose deleted commit points in IndexDeletionPolicy
Posted by GitBox <gi...@apache.org>.
dnhatn commented on pull request #158:
URL: https://github.com/apache/lucene/pull/158#issuecomment-850650666
@mikemccand Would you mind taking a look? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org