You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lsc713 (via GitHub)" <gi...@apache.org> on 2026/07/24 07:17:37 UTC
[PR] MINOR: Add toString test coverage for Bytes [kafka]
lsc713 opened a new pull request, #22922:
URL: https://github.com/apache/kafka/pull/22922
`BytesTest` covered `equals`, `hashCode`, `compareTo`, `wrap`, and the constructor, but `Bytes.toString()` had no test. This adds a test for its hex-escaping behavior:
- printable ASCII (0x20–0x7E) is kept as-is
- backslash (0x5C) is intentionally hex-escaped to `\x5C`
- control and high bytes are escaped to uppercase `\xHH`
- empty input and mixed printable/non-printable input are covered
No production code changes; unit test only, with no external dependencies.
This is my original work and I license it to the project under the project's open source license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20834: Add toString test coverage for Bytes [kafka]
Posted by "lsc713 (via GitHub)" <gi...@apache.org>.
lsc713 commented on PR #22922:
URL: https://github.com/apache/kafka/pull/22922#issuecomment-5125070401
Hi @chia7712, would you mind taking a look when you have a chance? This adds the missing `Bytes.toString()` coverage following the recent `BytesTest` improvements in #21913. The CI workflow also appears to be waiting for maintainer approval. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20834: Add toString test coverage for Bytes [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22922:
URL: https://github.com/apache/kafka/pull/22922#issuecomment-5262042446
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20834: Add toString test coverage for Bytes [kafka]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #22922:
URL: https://github.com/apache/kafka/pull/22922#issuecomment-5339462811
LGTM, thank you @lsc713!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org