You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/06/24 20:31:03 UTC
(datafusion) 01/01: chore(physical-plan): remove deprecated RowIndex struct (Closes #23080 - partial) (#23143)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-23143-d0f8c340e888e42b151d5c8964692f37c9655251
in repository https://gitbox.apache.org/repos/asf/datafusion.git
commit a4342cb1e90230112d5c393120a240368e264b86
Author: Giorgio Maria Federico Birnthaler <12...@users.noreply.github.com>
AuthorDate: Wed Jun 24 22:30:41 2026 +0200
chore(physical-plan): remove deprecated RowIndex struct (Closes #23080 - partial) (#23143)
Fixes part of #23080
## Summary
Removes the deprecated `RowIndex` struct from
`datafusion-physical-plan`. The whole
`datafusion/physical-plan/src/sorts/index.rs` file (61 lines, just the
doc-block + struct) is deleted because it was never declared in
`sorts/mod.rs` and never re-exported via `pub use` — it was a dead file
already. A grep across the workspace confirms zero remaining callers
even of the doc comment's identifier, and zero public re-exports. The
6-major-version grace period cited by the API-health policy is past due
(deprecated in 46.0.0, we are now on 55.x).
## Test plan
- `git grep -nE '\bRowIndex\b'` returns no matches in source or docs
(false-positives filtered: `FileRowIndexFunc` is a separate,
undeprecated symbol).
- `sorts/mod.rs` does not declare `mod index;`, so removing the on-disk
file is sufficient — no `mod` cleanup needed.
- The `datafusion-physical-plan` crate still builds cleanly across all
other sort modules.
AI assistance: drafted with the help of an Anthropic coding assistant.
Diff was reviewed line by line before submission, and the change was
verified independently.
Signed-off-by: Dodothereal
<12...@users.noreply.github.com>
Signed-off-by: Dodothereal <12...@users.noreply.github.com>
---
datafusion/physical-plan/src/sorts/index.rs | 61 -----------------------------
1 file changed, 61 deletions(-)
diff --git a/datafusion/physical-plan/src/sorts/index.rs b/datafusion/physical-plan/src/sorts/index.rs
deleted file mode 100644
index 29441e3f1f..0000000000
--- a/datafusion/physical-plan/src/sorts/index.rs
+++ /dev/null
@@ -1,61 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-/// A `RowIndex` identifies a specific row in a logical stream.
-///
-/// Each stream is identified by an `stream_idx` and is formed from a
-/// sequence of RecordBatches batches, each of which is identified by
-/// a unique `batch_idx` within that stream.
-///
-/// This is used by `SortPreservingMergeStream` to identify which
-/// the order of the tuples in the final sorted output stream.
-///
-/// ```text
-/// ┌────┐ ┌────┐ ┌────┐ RecordBatch
-/// │ │ │ │ │ │
-/// │ C1 │ │... │ │ CN │◀─────── (batch_idx = 0)
-/// │ │ │ │ │ │
-/// └────┘ └────┘ └────┘
-/// ┌────┐ ┌────┐ ┌────┐ RecordBatch
-/// │ │ │ │ │ │
-/// │ C1 │ │... │ │ CN │◀─────── (batch_idx = 1)
-/// │ │ │ │ │ │
-/// └────┘ └────┘ └────┘
-/// ┌────┐
-/// │ │ ...
-/// │ C1 │
-/// │ │ ┌────┐ RecordBatch
-/// └────┘ │ │
-/// │ CN │◀────── (batch_idx = M-1)
-/// │ │
-/// └────┘
-///
-///"Stream"s each with Stream N has M
-/// a potentially RecordBatches
-///different number of
-/// RecordBatches
-/// ```
-#[derive(Debug, Clone)]
-#[deprecated(since = "46.0.0", note = "unused and will be removed in the future")]
-pub struct RowIndex {
- /// The index of the stream (uniquely identifies the stream)
- pub stream_idx: usize,
- /// The index of the batch within the stream's VecDequeue.
- pub batch_idx: usize,
- /// The row index within the batch
- pub row_idx: usize,
-}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org