You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/27 14:02:50 UTC

[GitHub] [arrow-rs] jwdeitch opened a new pull request #874: add ilike comparitor

jwdeitch opened a new pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874


   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #873.
   
   # Rationale for this change
    
   <!---
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   adding `ilike` comparison operator to bring more pgSQL compatibility ultimately into datafusion
   
   <!---
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] jwdeitch commented on a change in pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
jwdeitch commented on a change in pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#discussion_r740210164



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -477,6 +477,122 @@ pub fn nlike_utf8_scalar<OffsetSize: StringOffsetSizeTrait>(
     Ok(BooleanArray::from(data))
 }
 
+/// Perform SQL `left ILIKE right` operation on [`StringArray`] /
+/// [`LargeStringArray`].
+///
+/// See the documentation on [`like_utf8`] for more details.
+pub fn ilike_utf8<OffsetSize: StringOffsetSizeTrait>(

Review comment:
       yeah that's a good call. I'll refactor that!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#issuecomment-955078979


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#874](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (baaad3a) into [master](https://codecov.io/gh/apache/arrow-rs/commit/05eb63f81ddbcfd9f597f893d200c3cda742262d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05eb63f) will **decrease** coverage by `0.12%`.
   > The diff coverage is `85.79%`.
   
   > :exclamation: Current head baaad3a differs from pull request most recent head bf1c495. Consider uploading reports for the commit bf1c495 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/874/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #874      +/-   ##
   ==========================================
   - Coverage   82.45%   82.33%   -0.13%     
   ==========================================
     Files         168      168              
     Lines       48175    48490     +315     
   ==========================================
   + Hits        39723    39923     +200     
   - Misses       8452     8567     +115     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [arrow-flight/src/arrow.flight.protocol.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3ctZmxpZ2h0L3NyYy9hcnJvdy5mbGlnaHQucHJvdG9jb2wucnM=) | `0.00% <ø> (ø)` | |
   | [arrow/src/array/cast.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2Nhc3QucnM=) | `85.71% <ø> (ø)` | |
   | [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `85.33% <ø> (-0.18%)` | :arrow_down: |
   | [arrow/src/csv/writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Nzdi93cml0ZXIucnM=) | `82.05% <ø> (-0.37%)` | :arrow_down: |
   | [arrow/src/error.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Vycm9yLnJz) | `13.33% <0.00%> (ø)` | |
   | [...ng/src/flight\_server\_scenarios/auth\_basic\_proto.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZWdyYXRpb24tdGVzdGluZy9zcmMvZmxpZ2h0X3NlcnZlcl9zY2VuYXJpb3MvYXV0aF9iYXNpY19wcm90by5ycw==) | `0.00% <0.00%> (ø)` | |
   | [parquet/src/data\_type.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZGF0YV90eXBlLnJz) | `76.84% <ø> (-0.48%)` | :arrow_down: |
   | [parquet/src/schema/parser.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvc2NoZW1hL3BhcnNlci5ycw==) | `85.11% <0.00%> (-1.26%)` | :arrow_down: |
   | [parquet/src/util/bit\_packing.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvdXRpbC9iaXRfcGFja2luZy5ycw==) | `99.96% <ø> (ø)` | |
   | [parquet/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvdXRpbC9iaXRfdXRpbC5ycw==) | `93.19% <ø> (+0.01%)` | :arrow_up: |
   | ... and [109 more](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05eb63f...bf1c495](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#issuecomment-964043098


   @jwdeitch  bf1c495 is a thing of beauty. Thank you so much for sticking with it. ❤️ 
   
   I kicked off CI and plan to merge this PR when it oasses


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] codecov-commenter commented on pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#issuecomment-955078979


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#874](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d17895) into [master](https://codecov.io/gh/apache/arrow-rs/commit/05eb63f81ddbcfd9f597f893d200c3cda742262d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05eb63f) will **increase** coverage by `0.01%`.
   > The diff coverage is `94.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/874/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #874      +/-   ##
   ==========================================
   + Coverage   82.45%   82.47%   +0.01%     
   ==========================================
     Files         168      168              
     Lines       48175    48298     +123     
   ==========================================
   + Hits        39723    39832     +109     
   - Misses       8452     8466      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `92.75% <94.44%> (+0.11%)` | :arrow_up: |
   | [arrow/src/ipc/writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2lwYy93cml0ZXIucnM=) | `84.28% <0.00%> (-1.74%)` | :arrow_down: |
   | [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `65.80% <0.00%> (+0.43%)` | :arrow_up: |
   | [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `67.04% <0.00%> (+0.45%)` | :arrow_up: |
   | [arrow/src/array/array\_union.rs](https://codecov.io/gh/apache/arrow-rs/pull/874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3VuaW9uLnJz) | `90.80% <0.00%> (+0.91%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05eb63f...2d17895](https://codecov.io/gh/apache/arrow-rs/pull/874?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a change in pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#discussion_r739658665



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -477,6 +477,122 @@ pub fn nlike_utf8_scalar<OffsetSize: StringOffsetSizeTrait>(
     Ok(BooleanArray::from(data))
 }
 
+/// Perform SQL `left ILIKE right` operation on [`StringArray`] /
+/// [`LargeStringArray`].
+///
+/// See the documentation on [`like_utf8`] for more details.
+pub fn ilike_utf8<OffsetSize: StringOffsetSizeTrait>(

Review comment:
       I realize you are just following the pattern of nlike, but this function is a lot of replication with the `like` kernel
   
   ![Screen Shot 2021-10-30 at 10 06 46 AM](https://user-images.githubusercontent.com/490673/139536207-409e7a6e-40db-4bac-afc6-333c9d1b7003.png)
   
   What do you think about refactoring so that the `like`, `nlike` and `ilike` kernels all share most of the same common code?
   
   Maybe something like this (untested)
   
   ```rust
   fn regex_like<OffsetSize, F>(
       left: &GenericStringArray<OffsetSize>,
       right: &GenericStringArray<OffsetSize>,
   ) -> Result<BooleanArray> 
   where 
     OffsetSize: StringOffsetSizeTrait,
     F: Fn(&str) -> Result<RegEx>
   {
   ...
               let re_pattern = pat.replace("%", ".*").replace("_", ".");
               let re = F(&re_pattern)?;
   ...
   }
   ```
   
   And then ilike turns into
   
   ```rust
   pub fn ilike_utf8<OffsetSize: StringOffsetSizeTrait>(
       left: &GenericStringArray<OffsetSize>,
       right: &GenericStringArray<OffsetSize>,
   ) -> Result<BooleanArray> {
     regex_like(left, right, |re_pattern| {
       Regex::new(&format!("(?i)^{}$", re_pattern)).map_err(|e| {
                   ArrowError::ComputeError(format!(
                       "Unable to build regex from ILIKE pattern: {}",
                       e
                   ))
               })
     })
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a change in pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#discussion_r745075374



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -477,6 +477,122 @@ pub fn nlike_utf8_scalar<OffsetSize: StringOffsetSizeTrait>(
     Ok(BooleanArray::from(data))
 }
 
+/// Perform SQL `left ILIKE right` operation on [`StringArray`] /
+/// [`LargeStringArray`].
+///
+/// See the documentation on [`like_utf8`] for more details.
+pub fn ilike_utf8<OffsetSize: StringOffsetSizeTrait>(

Review comment:
       > Or I can otherwise add an additional parameter to regex_like that will negate the match. I can get a change pushed today with your guidance :)
   
   I think we should go with whatever will be simpler to understand (even if it has some code duplication).
   
   I hope that is useful guidance 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb edited a comment on pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#issuecomment-964043098


   @jwdeitch  bf1c495 is a thing of beauty. Thank you so much for sticking with it. ❤️ 
   
   I kicked off CI and plan to merge this PR when it passes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a change in pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#discussion_r745018423



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -477,6 +477,122 @@ pub fn nlike_utf8_scalar<OffsetSize: StringOffsetSizeTrait>(
     Ok(BooleanArray::from(data))
 }
 
+/// Perform SQL `left ILIKE right` operation on [`StringArray`] /
+/// [`LargeStringArray`].
+///
+/// See the documentation on [`like_utf8`] for more details.
+pub fn ilike_utf8<OffsetSize: StringOffsetSizeTrait>(

Review comment:
       Hi @jwdeitch  -- I am planning to make a `6.2.0` release candidate later this week (Thursday or Friday) and I think this would be a great PR to get in by then.
   
   Do you plan to do the refactoring as part of this PR, or shall I merge this one and we can refactor as a follow on?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#issuecomment-964173930


   Thanks again @jwdeitch 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb merged pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] jwdeitch commented on a change in pull request #874: add ilike comparitor

Posted by GitBox <gi...@apache.org>.
jwdeitch commented on a change in pull request #874:
URL: https://github.com/apache/arrow-rs/pull/874#discussion_r745020749



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -477,6 +477,122 @@ pub fn nlike_utf8_scalar<OffsetSize: StringOffsetSizeTrait>(
     Ok(BooleanArray::from(data))
 }
 
+/// Perform SQL `left ILIKE right` operation on [`StringArray`] /
+/// [`LargeStringArray`].
+///
+/// See the documentation on [`like_utf8`] for more details.
+pub fn ilike_utf8<OffsetSize: StringOffsetSizeTrait>(

Review comment:
       Hey Andrew! sorry for the delay, I've been trying to get the `not like` functionality incorporated into this without relying on a negative look-ahead in the regex expression (which I assume will be have negative performance impact). Or I can otherwise add an additional parameter to `regex_like` that will negate the match. I can get a change pushed today with your guidance :) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org