You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/09/19 11:01:33 UTC

[PR] Tighten Hop Web UI spacing and margins, fixes #8461 (hop)

mattcasters opened a new pull request, #8462:
URL: https://github.com/apache/hop/pull/8462

   Tighten Hop Web spacing, paddings, and margins to bring them in line with the desktop Hop GUI, fixing #8461.
   
   ### Root Causes Addressed
   
   1. **Native Zoom Inflation on Web (`PropsUi`)**:
      - `PropsUi.reCalculateNativeZoomFactor()` previously set `nativeZoomFactor = globalZoom / 0.75` (1.333×) on Web.
      - This caused `PropsUi.getMargin()` to inflate from 8px to 11px (+37.5%) and `PropsUi.getFormMargin()` from 5px to 7px (+40%), cascading inflated spacing across every dialog, composite, and widget boundary.
      - In modern Hop Web, pipeline/workflow canvas rendering is handled independently by SVG renderers with their own zoom scaling, making this global layout distortion unnecessary.
      - **Fix**: Adjusted `nativeZoomFactor` to `1.0 * globalZoom` on Web, restoring `margin = 8px` and `formMargin = 5px`.
   
   2. **Web Toolbar Row & Composite Gaps**:
      - Web toolbar `RowLayout` used `spacing = 4`, and button item composites used `horizontalSpacing = 4`.
      - Separators were 6px wide with 6px vertical padding.
      - **Fix**: Reduced toolbar `RowLayout.spacing` to `1px`, button composite `horizontalSpacing` to `2px`, and separators to 5px width with 4px vertical padding.
   
   3. **Loose RAP CSS Theme Padding / Spacing**:
      - RAP CSS applied generous padding across controls (5px vertical padding on table/tree cells, 6px padding on combo items, 8px padding on CTabItems, 20px top margin on group frames).
      - **Fix**: Tightened RAP CSS definitions in both `light-mode.css` and `dark-mode.css` (`Tree-Cell`, `Table-Cell`, `TreeColumn`, `TableColumn`, `ToolBar[FLAT]`, `ToolItem`, `Text`, `CLabel`, `Button`, `Combo`, `CCombo`, `CTabItem`, `Group-Frame`, `Group-Label`, `Shell-Titlebar`, `List-Item`, `MenuItem`).
   
   ---
   
   ### Verification
   - Spotless code formatting passed (`./mvnw spotless:apply -pl ui,rap`).
   - Automated unit tests passed with isolated display (`tools/with-isolated-display.sh ./mvnw test -pl ui,rap` — 113 tests, 0 failures).
   - Build and Checkstyle verification passed (`tools/with-isolated-display.sh ./mvnw -T10 -pl ui,rap clean install -DskipTests`).
   
   Fixes #8461
   
   ------------------------
   
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
   - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Tighten Hop Web UI spacing and margins, fixes #8461 (hop)

Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters merged PR #8462:
URL: https://github.com/apache/hop/pull/8462


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org