[GitHub] [incubator-druid] jihoonson commented on issue #6726: #6336 causes overlord console page loading to be extreme slow

[GitBox <gi...@apache.org>]

jihoonson commented on issue #6726: #6336 causes overlord console page loading to be extreme slow
URL: https://github.com/apache/incubator-druid/issues/6726#issuecomment-491426013
 
 
   @QiuMM thanks. I'm looking forward to your PR.
   
   @FaxianZhao yeah, fine-grained locking would mitigate this issue. But, synchronizing `taskLock` isn't enough to fix the issue of https://github.com/apache/incubator-druid/pull/6336, because `taskLock` is shared by the tasks of the same groupId but the tasks of different groupIds should be able to request segment allocation for the same dataSource and interval at the same time. Check out https://github.com/apache/incubator-druid/issues/7491.
   
   I think the best way to handle this is synchronizing segmentId allocation per dataSource per interval as @QiuMM did [here](https://github.com/apache/incubator-druid/pull/6336#issuecomment-450610474).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org