You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/08 09:34:18 UTC
[jira] [Commented] (BEAM-2410) Remove TransportClient from
ElasticSearchIO to decouple IO and ES versions
[ https://issues.apache.org/jira/browse/BEAM-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042456#comment-16042456 ]
ASF GitHub Bot commented on BEAM-2410:
--------------------------------------
GitHub user echauchot opened a pull request:
https://github.com/apache/beam/pull/3328
[BEAM-2410] Remove TransportClient from ElasticSearchIO
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`.
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
This PR is a first step to support Elasticsearch 5.x but it is also very useful for the IO that supports Elasticsearch 2.x, hence the separate PR.
R: @jbonofre
R: @jkff
CC: @ssisk regarding my comment https://issues.apache.org/jira/browse/BEAM-2347?focusedCommentId=16022861&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16022861
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echauchot/beam BEAM-2410-ELASTICSEARCHIO-REMOVE-TRANSPORTCLIENT
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3328
----
commit a41afd46dc6f057ec7eea24c3ab2ff996258e5f6
Author: Etienne Chauchot <ec...@gmail.com>
Date: 2017-06-05T14:21:58Z
[BEAM-2410] Remove TransportClient from ElasticSearchIO to decouple IO and ES server versions
----
> Remove TransportClient from ElasticSearchIO to decouple IO and ES versions
> --------------------------------------------------------------------------
>
> Key: BEAM-2410
> URL: https://issues.apache.org/jira/browse/BEAM-2410
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-extensions
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
>
> Elasticsearch IO uses TransportClient in tests (UT and IT) but uses RestClient in the production code. TransportClient version is coupled with Elasticsearch server version. Use RestClient everywhere to lower the coupling.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)