You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/13 21:04:54 UTC
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #566: [YUNIKORN-1797] Core: Implement scoped logging
codecov[bot] commented on PR #566:
URL: https://github.com/apache/yunikorn-core/pull/566#issuecomment-1590025693
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#566](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ede7244) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/dc71c15018724e961254b63498f1e651a1f017a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dc71c15) will **increase** coverage by `0.01%`.
> The diff coverage is `75.15%`.
```diff
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 75.00% 75.01% +0.01%
==========================================
Files 72 73 +1
Lines 11542 11615 +73
==========================================
+ Hits 8657 8713 +56
- Misses 2581 2598 +17
Partials 304 304
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/log/filtered\_core.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2xvZy9maWx0ZXJlZF9jb3JlLmdv) | `43.75% <43.75%> (ø)` | |
| [pkg/webservice/handlers.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `80.26% <66.66%> (+0.46%)` | :arrow_up: |
| [pkg/log/logger.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | `78.98% <72.64%> (-0.51%)` | :arrow_down: |
| [pkg/common/configs/configs.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3MuZ28=) | `85.18% <100.00%> (+1.51%)` | :arrow_up: |
| [pkg/scheduler/objects/node.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `82.60% <100.00%> (+0.04%)` | :arrow_up: |
| [pkg/scheduler/placement/filter.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvZmlsdGVyLmdv) | `89.83% <100.00%> (+0.08%)` | :arrow_up: |
| [pkg/scheduler/placement/placement.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcGxhY2VtZW50Lmdv) | `83.21% <100.00%> (-0.13%)` | :arrow_down: |
| [pkg/webservice/state\_dump.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `70.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org