[GitHub] [tvm] junrushao commented on a diff in pull request #15652: [Runtime] Add ShapeTupleObj::Numel and ShapeTuple Printing

["junrushao (via GitHub)" <gi...@apache.org>]

junrushao commented on code in PR #15652:
URL: https://github.com/apache/tvm/pull/15652#discussion_r1313190374


##########
include/tvm/runtime/container/shape_tuple.h:
##########
@@ -42,6 +43,9 @@ class ShapeTupleObj : public Object {
   /*! \brief The size of the shape tuple object. */
   uint64_t size;
 
+  /*! \brief Get number of elements in the shape */
+  index_type Numel() const;

Review Comment:
   Both torch and matlab uses “numel”, and numpy uses “size” but we have already used this word for a different meaning



##########
include/tvm/runtime/container/shape_tuple.h:
##########
@@ -42,6 +43,9 @@ class ShapeTupleObj : public Object {
   /*! \brief The size of the shape tuple object. */
   uint64_t size;
 
+  /*! \brief Get number of elements in the shape */
+  index_type Numel() const;

Review Comment:
   Both torch and matlab uses “numel”, and numpy uses “size” but we have already used this word for a different meaning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org