You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 06:30:28 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #27085: Support parsing Oracle CREATE TABLE sql

FlyingZC opened a new issue, #27085:
URL: https://github.com/apache/shardingsphere/issues/27085

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   CREATE TABLE admin_docindex2(
           token CHAR(20), 
           doc_id NUMBER,
           token_frequency NUMBER,
           token_offsets VARCHAR2(2000),
           CONSTRAINT pk_admin_docindex2 PRIMARY KEY (token, doc_id))
       ORGANIZATION INDEX 
       TABLESPACE admin_tbs
       PCTTHRESHOLD 20
       INCLUDING token_frequency
       OVERFLOW TABLESPACE admin_tbs2;
   ```
   
   ```sql
   CREATE TABLE countries_demo
       ( country_id      CHAR(2)
         CONSTRAINT country_id_nn_demo NOT NULL
       , country_name    VARCHAR2(40)
       , currency_name   VARCHAR2(25)
       , currency_symbol VARCHAR2(3)
       , region          VARCHAR2(15)
       , CONSTRAINT    country_c_id_pk_demo
                       PRIMARY KEY (country_id ) )
       ORGANIZATION INDEX 
       INCLUDING   country_name 
       PCTTHRESHOLD 2 
       STORAGE 
        ( INITIAL  4K ) 
      OVERFLOW 
       STORAGE 
         ( INITIAL  4K );
   ```
   
   ```sql
   CREATE TABLE customers
   (PARTITION BY RANGE (cust_year_of_birth)
    PARTITION p1 VALUES LESS THAN (1945),
    PARTITION p2 VALUES LESS THAN (1950), 
    PARTITION p3 VALUES LESS THAN (1955),
    PARTITION p4 VALUES LESS THAN (1960),
    PARTITION p5 VALUES LESS THAN (1965),
    PARTITION p6 VALUES LESS THAN (1970);
   ```
   
   ```sql
   CREATE TABLE deptXTec3
    ORGANIZATION EXTERNAL (TYPE ORACLE_DATAPUMP DEFAULT DIRECTORY def_dir1
    ACCESS PARAMETERS (COMPRESSION ENABLED) LOCATION ('dept.dmp'));
   ```
   
   ```sql
   CREATE TABLE customer_addresses (
      add_id NUMBER,
      address REF cust_address_typ REFERENCES address_table);
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #27085:
URL: https://github.com/apache/shardingsphere/issues/27085#issuecomment-1962855010

   @zzzk1 Assigned. Please go ahead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #27085: Support parsing Oracle CREATE TABLE sql
URL: https://github.com/apache/shardingsphere/issues/27085


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #27085:
URL: https://github.com/apache/shardingsphere/issues/27085#issuecomment-5329020538

   Hi @FlyingZC, thanks for reporting this. The Oracle `CREATE TABLE` parsing capabilities listed in this issue are already supported on the current master, so we will close it as completed.
   
   For the record:
   
   - `ORGANIZATION INDEX ... PCTTHRESHOLD ... OVERFLOW TABLESPACE` is covered by the `organizationClause` / `indexOrgTableClause` / `indexOrgOverflowClause` grammar rules, with the `create_table_organization_index` SQL case verified in `SQLParserParameterizedTest` (added in #29252).
   - `ORGANIZATION INDEX ... INCLUDING ... STORAGE ... OVERFLOW` is covered by `indexOrgOverflowClause` and `segmentAttributesClause` (which includes `storageClause`).
   - `ORGANIZATION EXTERNAL (TYPE ...)` is covered by `externalTableClause`, where the access driver type is parsed as an identifier, so `ORACLE_DATAPUMP` works the same as the tested `ORACLE_LOADER` case (`create_table_with_enclosed`).
   - `REF ... REFERENCES` columns are covered by the `create_table_ref_type1/2` SQL cases (added in #29342).
   - `PARTITION BY RANGE` table definitions are covered by existing partitioning grammar rules and SQL cases. Note the third SQL in the issue description is not valid Oracle syntax (unbalanced parenthesis), so it needs no handling per the issue's own step 1.
   
   @zzzk1, thanks for taking this earlier — since the work has been completed by other PRs in the meantime, no further change is needed. If anyone finds a variant that still fails to parse on the latest version, please open a new issue with the exact SQL. Closing this one now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]

Posted by "zzzk1 (via GitHub)" <gi...@apache.org>.
zzzk1 commented on issue #27085:
URL: https://github.com/apache/shardingsphere/issues/27085#issuecomment-1962848504

   Hi, @strongduanmu pls assign this issue to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #27085: Support parsing Oracle CREATE TABLE sql

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27085:
URL: https://github.com/apache/shardingsphere/issues/27085#issuecomment-1676080762

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27085:
URL: https://github.com/apache/shardingsphere/issues/27085#issuecomment-2021367932

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE TABLE sql [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27085:
URL: https://github.com/apache/shardingsphere/issues/27085#issuecomment-1784213118

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org