[GitHub] [spark] ueshin commented on a diff in pull request #40747: [SPARK-43099][SQL] Use `getName` instead of `getCanonicalName` to get builder class name when registering udf to FunctionRegistry

["ueshin (via GitHub)" <gi...@apache.org>]

ueshin commented on code in PR #40747:
URL: https://github.com/apache/spark/pull/40747#discussion_r1167330527


##########
sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala:
##########
@@ -1060,4 +1060,11 @@ class UDFSuite extends QueryTest with SharedSparkSession {
     }.getCause.getCause
     assert(e.isInstanceOf[java.lang.ArithmeticException])
   }
+
+  test("SPARK-43099: UDF className is correctly populated") {
+    spark.udf.register("dummyUDF", (x: Int) => x + 1)
+    val expressionInfo = spark.sessionState.catalog
+      .lookupFunctionInfo(FunctionIdentifier("dummyUDF"))
+    assert(expressionInfo.getClassName.contains("org.apache.spark.sql.UDFRegistration$$Lambda"))

Review Comment:
   Does this test pass with JDK15+?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org