You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/06/21 07:32:00 UTC

[jira] [Commented] (IMPALA-11369) Have separate thrift compiler for different component

    [ https://issues.apache.org/jira/browse/IMPALA-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556700#comment-17556700 ] 

ASF subversion and git services commented on IMPALA-11369:
----------------------------------------------------------

Commit 06b1db4675b509b9461f7489d81a2c74930aa413 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=06b1db467 ]

IMPALA-11369: Separate thrift compiler for different component

Impala used to have one thrift compiler version to compile C++, Java,
and Python code.

Most Thrift serialization/deserialization between minor versions are
compatible with each other. So it is possible to have different thrift
compiler versions for different target codes. It is beneficial to do so
because it will allow Impala to upgrade separate components
independently.

This patch implements the infrastructure change required to do so. It
replace most of the 'THRIFT_*' environment variable and CMake variable
with 'THRFIT_CPP_*', 'THRFIT_JAVA_*', and 'THRFIT_PY_*' to compile C++,
Java, and Python code accordingly. All three still refer to the same
thrift version (thrift-0.11.0-p5).

Testing:
- Build Impala and pass core tests.

Change-Id: I56479dc69b79024d1a4d09211bbe88a61fa0c6a4
Reviewed-on: http://gerrit.cloudera.org:8080/18636
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Have separate thrift compiler for different component
> -----------------------------------------------------
>
>                 Key: IMPALA-11369
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11369
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 4.1.0
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>
> Currently Impala use one thrift compiler version to compile C++, Java, and Python code.
> However, Thrift serialization/deserialization between minor version is mostly compatible with each other. So it is possible to have different thrift compiler version for different target code. It is also beneficial to do so because different component can then be upgraded independently.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org