You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2005/04/24 21:25:12 UTC
cvs commit: jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client ReceiveSubscriber.java
sebb 2005/04/24 12:25:12
Modified: src/protocol/jms/org/apache/jmeter/protocol/jms/client
ReceiveSubscriber.java
Log:
Fix some Runtime Exceptions
Revision Changes Path
1.4 +14 -6 jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
Index: ReceiveSubscriber.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ReceiveSubscriber.java 4 Nov 2004 02:23:57 -0000 1.3
+++ ReceiveSubscriber.java 24 Apr 2005 19:25:12 -0000 1.4
@@ -40,19 +40,19 @@
*/
public class ReceiveSubscriber implements Runnable {
- static Logger log = LoggingManager.getLoggerForClass();
+ private static Logger log = LoggingManager.getLoggerForClass();
private TopicConnection CONN = null;
private TopicSession SESSION = null;
private Topic TOPIC = null;
private TopicSubscriber SUBSCRIBER = null;
private byte[] RESULT = null;
- private Object OBJ_RESULT = null;
- private long time = System.currentTimeMillis();
+ private Object OBJ_RESULT = null;//TODO never read
+ //private long time = System.currentTimeMillis();
private int counter;
- private int loop = 1;
+ private int loop = 1; //TODO never read
private StringBuffer buffer = new StringBuffer();
- private boolean RUN = true;
+ private volatile boolean RUN = true;// Needs to be volatile to ensure value is picked up
private Thread CLIENTTHREAD = null;
/**
@@ -104,7 +104,7 @@
*/
public void initConnection(Context ctx, String connfactory, String topic){
try {
- TopicConnectionFactory connfac =
+ TopicConnectionFactory connfac = //TODO never read
ConnectionFactory.getTopicConnectionFactory(ctx,connfactory);
this.CONN = ConnectionFactory.getTopicConnection();
this.TOPIC = InitialContextFactory.lookupTopic(ctx,topic);
@@ -129,6 +129,10 @@
* messages from the JMS provider.
*/
public void resume(){
+ if (this.CONN==null){
+ log.error("Connection not set up");
+ return;
+ }
try {
this.CONN.start();
} catch (JMSException e){
@@ -236,6 +240,10 @@
protected void listen() {
log.info("Subscriber2.listen() called");
while (RUN) {
+ if (SUBSCRIBER == null){
+ log.error("Subscriber has not been set up");
+ break;
+ }
try {
Message message = this.SUBSCRIBER.receive();
if (message != null && message instanceof TextMessage) {
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org