You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/09/24 20:30:48 UTC

[GitHub] sijie commented on a change in pull request #2640: [tests] Issue 2639: NullPointerException at closing consumer

sijie commented on a change in pull request #2640: [tests] Issue 2639: NullPointerException at closing consumer
URL: https://github.com/apache/pulsar/pull/2640#discussion_r219978225
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -693,6 +693,11 @@ public void connectionFailed(PulsarClientException exception) {
 
         CompletableFuture<Void> closeFuture = new CompletableFuture<>();
         ClientCnx cnx = cnx();
+        if (null == cnx) {
 
 Review comment:
   @merlimat I addressed your comment. can you take a look again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services