You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Laird Nelson (JIRA)" <ji...@apache.org> on 2018/06/27 22:05:00 UTC
[jira] [Created] (MNG-6435) DefaultSettingsBuilder assumes all
SettingsReader/Writer impls will use XML
Laird Nelson created MNG-6435:
---------------------------------
Summary: DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
Key: MNG-6435
URL: https://issues.apache.org/jira/browse/MNG-6435
Project: Maven
Issue Type: Bug
Components: Settings
Affects Versions: 3.5.3
Reporter: Laird Nelson
On or around line 234, interpolation of settings assumes XML:
{code}
interpolator.addPostProcessor( new InterpolationPostProcessor()
{
@Override
public Object execute( String expression, Object value )
{
if ( value != null )
{
// we're going to parse this back in as XML so we need to escape XML markup
value = value.toString().replace( "&", "&" ).replace( "<", "<" ).replace( ">", ">" );
return value;
}
return null;
}
} );
{code}
The expression being interpolated here is the result of a {{SettingsWriter}}'s output. Obviously this kind of escaping doesn't make any sense if the {{SettingsWriter}} in question is not XML-based.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)