Re: Review Request 74476: RANGER-4081 : If the url to edit a policy, service or permissions for a module, and the url to view user/group/roles contains an invalid id, then page should display an error.

[Mugdha Varadkar <mu...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74476/#review225558
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On June 13, 2023, 9:56 a.m., Dhaval Rajpara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74476/
> -----------------------------------------------------------
> 
> (Updated June 13, 2023, 9:56 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4081
>     https://issues.apache.org/jira/browse/RANGER-4081
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> If the url to edit a policy, a service or permissions for a certain module contains an invalid service id or a policy id, 
> then the page is stuck in loading state. 
> Ideally, if the service or a policy for a given id does not exist, then the page should
> display the appropriate error message.
> 
> If the url to view the user/group/role details also has an invalid id, the page is stuck in loading state instead of displaying an error.
> 
> For example, if the url to edit a security zone contains an invalid zone id, there is a popup that displays the message "Data not found for given id". A similar message should be displayed for other urls with invalid ids.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 356b01f3c 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 8030fe7a4 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 6348d0287 
>   security-admin/src/main/webapp/react-webapp/src/App.jsx 28df2d026 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js be1c2cbb8 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js ec4258d24 
>   security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js 86f8fb79d 
>   security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx 6ed0ed9a8 
>   security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx f27f4de40 
>   security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx f2570e458 
>   security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx ee3d21d15 
>   security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx 606b56832 
>   security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx 1324a856c 
>   security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx fe66cfe01 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx 8f1271a36 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 8d03c3ffd 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx e1fd5c0d8 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx 8052593de 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx 313c4c4a6 
>   security-admin/src/main/webapp/scripts/model_bases/RangerServiceDefBase.js 7fb6e12bf 
>   security-admin/src/main/webapp/scripts/models/RangerServiceDef.js 210376f1a 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 0a332fc23 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 200fdeab5 
>   security-admin/src/main/webapp/scripts/views/common/ErrorView.js 63dceb77e 
>   security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 10ac8b65f 
> 
> 
> Diff: https://reviews.apache.org/r/74476/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
>   -> CRUD Operation in service, policy,users, Groups and Role module.
>   -> verified the all listing pages with invalid ID and its gives error page
>   -> when users enters the invalid id in url the UI will show the DATA NOT FOUND page and provide the GOBack Button.
>   -> If user enter wronge URL its give 404 page not found error page.
> 
> 
> Thanks,
> 
> Dhaval Rajpara
> 
>