[GitHub] [lucene-solr] gus-asf commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

[GitBox <gi...@apache.org>]

gus-asf commented on pull request #1966:
URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705761838


   HI @uschindler , your comments sound like you think I will be unwilling to take feedback. I'm not sure why you feel this way and seem to need to say the same thing repeatedly. This is broken out from the original contribution ticket for the very purpose of getting feedback. That said I do have a concern with the solution that FilteringTokenFilter provides... Consider this case:
   
   Text: "January 401(k) contribution"
   Whitespace tok: "January"(pi:1) "401l"(pi1) "contribution"(pi1)
   PatternTypingFilter: "January"(pi:1), "401(k)"(pi1:flag:2, type:legal2_401_k), "contribution"(pi:1)
   TokenAnalyzerFilter:"january"(pi:1),"401"(pi1:flag:2, type:legal2_401_k),"k",  "contribution"(pi:1)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org