You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Jukka Zitting <ju...@gmail.com> on 2013/06/14 10:28:41 UTC

Re: svn commit: r1492995 - /jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexEditor.java

Hi,

On Fri, Jun 14, 2013 at 11:22 AM,  <al...@apache.org> wrote:
> +    private AtomicLong indexedNodes;

A normal long should be fine here, as the editor instance isn't being
accessed concurrently from multiple threads.

BR,

Jukka Zitting

Re: svn commit: r1492995 - /jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexEditor.java

Posted by Alex Parvulescu <al...@gmail.com>.
As it turns out, using a normal Long doesn't work (because of primitive
unwrapping we lose the original reference).

As per Jukka's suggestions I'm looking into introducing a context class to
wrap all the baggage we pass from the 'parent' and this counter as well.


On Fri, Jun 14, 2013 at 10:41 AM, Alex Parvulescu <alex.parvulescu@gmail.com
> wrote:

> good point, I was thinking about concurrent commits, but that's not how it
> works.
> I'll change to a normal long then
>
> thanks,
> alex
>
>
> On Fri, Jun 14, 2013 at 10:28 AM, Jukka Zitting <ju...@gmail.com>wrote:
>
>> Hi,
>>
>> On Fri, Jun 14, 2013 at 11:22 AM,  <al...@apache.org> wrote:
>> > +    private AtomicLong indexedNodes;
>>
>> A normal long should be fine here, as the editor instance isn't being
>> accessed concurrently from multiple threads.
>>
>> BR,
>>
>> Jukka Zitting
>>
>
>

Re: svn commit: r1492995 - /jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexEditor.java

Posted by Alex Parvulescu <al...@gmail.com>.
good point, I was thinking about concurrent commits, but that's not how it
works.
I'll change to a normal long then

thanks,
alex


On Fri, Jun 14, 2013 at 10:28 AM, Jukka Zitting <ju...@gmail.com>wrote:

> Hi,
>
> On Fri, Jun 14, 2013 at 11:22 AM,  <al...@apache.org> wrote:
> > +    private AtomicLong indexedNodes;
>
> A normal long should be fine here, as the editor instance isn't being
> accessed concurrently from multiple threads.
>
> BR,
>
> Jukka Zitting
>