You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/14 21:56:45 UTC
[GitHub] [arrow] kszucs opened a new pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
kszucs opened a new pull request #10329:
URL: https://github.com/apache/arrow/pull/10329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#discussion_r633367479
##########
File path: ci/scripts/java_jni_build.sh
##########
@@ -21,21 +21,20 @@ set -e
arrow_dir=${1}
cpp_build_dir=${2}
-copy_jar_to_distribution_folder=${3:-true}
java_dir=${arrow_dir}/java
export ARROW_TEST_DATA=${arrow_dir}/testing/data
pushd $java_dir
- # build the entire project
- mvn clean install -DskipTests -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
- # test jars that have cpp dependencies
- mvn test -P arrow-jni -pl adapter/orc,gandiva,dataset -Dgandiva.cpp.build.dir=$cpp_build_dir
- if [[ $copy_jar_to_distribution_folder ]] ; then
- # copy the jars that has cpp dependencies to distribution folder
- find gandiva/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- find adapter/orc/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- find dataset/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- fi
+# build the entire project
+mvn clean install -DskipTests -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
+# test jars that have cpp dependencies
+mvn test -P arrow-jni -pl adapter/orc,gandiva,dataset -Dgandiva.cpp.build.dir=$cpp_build_dir
+
+# copy the jars that has cpp dependencies to distribution folder
+find gandiva/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
+find adapter/orc/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
+find dataset/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
Review comment:
Thanks @anthonylouisbsb for the heads up! I'm going to incorporate it to the script!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842176800
> @andygrove told that we can use `mvn deploy:deploy-file`: [#9155 (comment)](https://github.com/apache/arrow/pull/9155#issuecomment-820826684)
Great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842520367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842519941
https://issues.apache.org/jira/browse/ARROW-12812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842228000
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842166197
> Can we also generate .jar that doesn't need to bundle C++ libraries as the next step? Then we don't need to generate any .jar in our release process.
@kou I was thinking of the exact same thing. Using Anthony's snippet above we can generate the jars, though I'm not sure how to upload them without recompiling the jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842283722
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842518235
The produced artifacts are here: https://github.com/ursacomputing/crossbow/releases/tag/actions-415-github-java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842171994
@andygrove told that we can use `mvn deploy:deploy-file`: https://github.com/apache/arrow/pull/9155#issuecomment-820826684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-841522714
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-843184678
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-843462405
Revision: 9b4ce8010ef7a1432df00e2de0fd16454e77a115
Submitted crossbow builds: [ursacomputing/crossbow @ actions-422](https://github.com/ursacomputing/crossbow/branches/all?query=actions-422)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-422-github-java-jars)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-841522714
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-845912678
Revision: 2583f7acac979bb68eebdb733184a36cb7024af0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-431](https://github.com/ursacomputing/crossbow/branches/all?query=actions-431)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-431-github-java-jars)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on a change in pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#discussion_r633111082
##########
File path: ci/scripts/java_jni_build.sh
##########
@@ -21,21 +21,20 @@ set -e
arrow_dir=${1}
cpp_build_dir=${2}
-copy_jar_to_distribution_folder=${3:-true}
java_dir=${arrow_dir}/java
export ARROW_TEST_DATA=${arrow_dir}/testing/data
pushd $java_dir
- # build the entire project
- mvn clean install -DskipTests -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
- # test jars that have cpp dependencies
- mvn test -P arrow-jni -pl adapter/orc,gandiva,dataset -Dgandiva.cpp.build.dir=$cpp_build_dir
- if [[ $copy_jar_to_distribution_folder ]] ; then
- # copy the jars that has cpp dependencies to distribution folder
- find gandiva/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- find adapter/orc/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- find dataset/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- fi
+# build the entire project
+mvn clean install -DskipTests -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
+# test jars that have cpp dependencies
+mvn test -P arrow-jni -pl adapter/orc,gandiva,dataset -Dgandiva.cpp.build.dir=$cpp_build_dir
+
+# copy the jars that has cpp dependencies to distribution folder
+find gandiva/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
+find adapter/orc/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
+find dataset/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
Review comment:
I think you can modify this block to generate the jars for all modules, my suggestion:
```shell
# build and test the entire project
mvn clean install -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
MODULES=(
gandiva adapter/orc adapter/avro adapter/jdbc dataset algorithm
compression format performance tools vector plasma flight/flight-core
flight/flight-grpc memory/memory-core memory/memory-netty memory/memory-unsafe
)
# copy all jars to distribution folder, excluding the unit tests ones
for module in "${MODULES[@]}"
do
find $module/target/ -name "*.jar" -not -name "*tests*" -not -name "*benchmarks*" -exec cp {} $cpp_build_dir \;
done
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842284641
Revision: 1479055bcf42ae48c7b824688a4211e04129d297
Submitted crossbow builds: [ursacomputing/crossbow @ actions-415](https://github.com/ursacomputing/crossbow/branches/all?query=actions-415)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-415-github-java-jars)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#discussion_r633367479
##########
File path: ci/scripts/java_jni_build.sh
##########
@@ -21,21 +21,20 @@ set -e
arrow_dir=${1}
cpp_build_dir=${2}
-copy_jar_to_distribution_folder=${3:-true}
java_dir=${arrow_dir}/java
export ARROW_TEST_DATA=${arrow_dir}/testing/data
pushd $java_dir
- # build the entire project
- mvn clean install -DskipTests -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
- # test jars that have cpp dependencies
- mvn test -P arrow-jni -pl adapter/orc,gandiva,dataset -Dgandiva.cpp.build.dir=$cpp_build_dir
- if [[ $copy_jar_to_distribution_folder ]] ; then
- # copy the jars that has cpp dependencies to distribution folder
- find gandiva/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- find adapter/orc/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- find dataset/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- fi
+# build the entire project
+mvn clean install -DskipTests -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
+# test jars that have cpp dependencies
+mvn test -P arrow-jni -pl adapter/orc,gandiva,dataset -Dgandiva.cpp.build.dir=$cpp_build_dir
+
+# copy the jars that has cpp dependencies to distribution folder
+find gandiva/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
+find adapter/orc/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
+find dataset/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
Review comment:
Thanks @anthonylouisbsb for the heads up! I'm going to incorporate it to the script!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-845870055
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on a change in pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#discussion_r633111082
##########
File path: ci/scripts/java_jni_build.sh
##########
@@ -21,21 +21,20 @@ set -e
arrow_dir=${1}
cpp_build_dir=${2}
-copy_jar_to_distribution_folder=${3:-true}
java_dir=${arrow_dir}/java
export ARROW_TEST_DATA=${arrow_dir}/testing/data
pushd $java_dir
- # build the entire project
- mvn clean install -DskipTests -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
- # test jars that have cpp dependencies
- mvn test -P arrow-jni -pl adapter/orc,gandiva,dataset -Dgandiva.cpp.build.dir=$cpp_build_dir
- if [[ $copy_jar_to_distribution_folder ]] ; then
- # copy the jars that has cpp dependencies to distribution folder
- find gandiva/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- find adapter/orc/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- find dataset/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
- fi
+# build the entire project
+mvn clean install -DskipTests -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
+# test jars that have cpp dependencies
+mvn test -P arrow-jni -pl adapter/orc,gandiva,dataset -Dgandiva.cpp.build.dir=$cpp_build_dir
+
+# copy the jars that has cpp dependencies to distribution folder
+find gandiva/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
+find adapter/orc/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
+find dataset/target/ -name "*.jar" -not -name "*tests*" -exec cp {} $cpp_build_dir \;
Review comment:
I think you can modify this block to generate the jars for all modules, my suggestion:
```shell
# build and test the entire project
mvn clean install -P arrow-jni -Darrow.cpp.build.dir=$cpp_build_dir
MODULES=(
gandiva adapter/orc adapter/avro adapter/jdbc dataset algorithm
compression format performance tools vector plasma flight/flight-core
flight/flight-grpc memory/memory-core memory/memory-netty memory/memory-unsafe
)
# copy all jars to distribution folder, excluding the unit tests ones
for module in "${MODULES[@]}"
do
find $module/target/ -name "*.jar" -not -name "*tests*" -not -name "*benchmarks*" -exec cp {} $cpp_build_dir \;
done
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-841522714
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842171994
@andygrove told that we can use `mvn deploy:deploy-file`: https://github.com/apache/arrow/pull/9155#issuecomment-820826684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10329: [Packaging][Java] Improve JNI jars build [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10329:
URL: https://github.com/apache/arrow/pull/10329#issuecomment-842284641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10329: ARROW-12812: [Packaging][Java] Improve JNI jars build
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10329:
URL: https://github.com/apache/arrow/pull/10329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org