You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bogdanrdc <gi...@git.apache.org> on 2017/07/07 11:48:20 UTC

[GitHub] spark pull request #18563: [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect ha...

GitHub user bogdanrdc opened a pull request:

    https://github.com/apache/spark/pull/18563

    [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect handling of structs

    ## What changes were proposed in this pull request?
    
    This is backport of https://github.com/apache/spark/pull/18455
    When data type is struct, InSet now uses TypeUtils.getInterpretedOrdering (similar to EqualTo) to build a TreeSet. In other cases it will use a HashSet as before (which should be faster). Similarly, In.eval uses Ordering.equiv instead of equals.
    
    ## How was this patch tested?
    New test in SQLQuerySuite.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bogdanrdc/spark SPARK-21228-BRANCH2.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18563.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18563
    
----
commit fe09c9a032e6931e021adf55d90a09a2ca818333
Author: Bogdan Raducanu <bo...@databricks.com>
Date:   2017-07-07T11:42:09Z

    ported fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #18563: [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect ha...

Posted by bogdanrdc <gi...@git.apache.org>.
Github user bogdanrdc closed the pull request at:

    https://github.com/apache/spark/pull/18563


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18563: [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect handling ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18563
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18563: [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect handling ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18563
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79333/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18563: [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect handling ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18563
  
    **[Test build #79333 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79333/testReport)** for PR 18563 at commit [`fe09c9a`](https://github.com/apache/spark/commit/fe09c9a032e6931e021adf55d90a09a2ca818333).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18563: [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect handling ...

Posted by bogdanrdc <gi...@git.apache.org>.
Github user bogdanrdc commented on the issue:

    https://github.com/apache/spark/pull/18563
  
    cc @cloud-fan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18563: [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect handling ...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/18563
  
    thanks, merging to 2.2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18563: [SPARK-21228][SQL][BRANCH-2.2] InSet incorrect handling ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18563
  
    **[Test build #79333 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79333/testReport)** for PR 18563 at commit [`fe09c9a`](https://github.com/apache/spark/commit/fe09c9a032e6931e021adf55d90a09a2ca818333).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org