You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/02/12 01:02:31 UTC

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22476


Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................

[consensus] avoid copying TrackedPeer on every response

PeerMessageQueue::TrackedPeer is quite a heavy structure, so it's better
avoid copying it when processing responses from Raft peers.  I also
updated the related code to follow the current style guidelines.

This patch is inspired by [1].

This changelist doesn't contain any functional modifications.

[1] https://github.com/facebook/kuduraft/commit/e04b6d03e

Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
2 files changed, 28 insertions(+), 20 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/22476/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22476 )

Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................


Patch Set 1: -Verified

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1064/


-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2025 03:05:11 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22476 )

Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1061/


-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2025 01:02:37 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22476 )

Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................

[consensus] avoid copying TrackedPeer on every response

PeerMessageQueue::TrackedPeer is quite a heavy structure, so it's better
avoid copying it when processing responses from Raft peers.  I also
updated the related code to follow the current style guidelines.

This patch is inspired by [1].

This changelist doesn't contain any functional modifications.

[1] https://github.com/facebook/kuduraft/commit/e04b6d03e

Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Reviewed-on: http://gerrit.cloudera.org:8080/22476
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
2 files changed, 28 insertions(+), 20 deletions(-)

Approvals:
  Yifan Zhang: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22476 )

Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................


Patch Set 1: Verified+1

unrelated test failures:
  * KUDU-3281
  * etc.


-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2025 07:58:28 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22476 )

Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1064/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2025 07:33:25 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22476 )

Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2025 06:04:00 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] avoid copying TrackedPeer on every response

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22476 )

Change subject: [consensus] avoid copying TrackedPeer on every response
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1061/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a2e38412a9c3434c580889d73a69af533f13d28
Gerrit-Change-Number: 22476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2025 02:00:27 +0000
Gerrit-HasComments: No