You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/26 07:28:28 UTC

[GitHub] [iotdb] alany9552 commented on pull request #4380: Fixed flaky tests

alany9552 commented on pull request #4380:
URL: https://github.com/apache/iotdb/pull/4380#issuecomment-979750021


   
   
   
   
   > Thanks for your job. However, I can not get your point, are you going to keep the order of map elements? if we use `Collections.synchronizedMap` relpace the `ConcurrentHashMap`, which may occur `ConcurrentModificationException`.
   
   Yeah I understand your concerns. The order of the map elements keeps the same and pass for the regular runs, but the order can't be guaranteed when running `NonDex` tests because `ConcurrentHashMap`. If using `ConcurrentHashMap` is the best in this situation as you mentioned the exception, it would be better to change the test code in that doesn't require orders, otherwise the tests will be keep flaky when running. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org