[jira] [Commented] (HIVE-6716) ORC struct throws NPE for tables with inner structs having null values

["Gunther Hagleitner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942678#comment-13942678 ] 

Gunther Hagleitner commented on HIVE-6716:
------------------------------------------

+1 LGTM, wondering though if it would be easy to write a unit test for it.

> ORC struct throws NPE for tables with inner structs having null values 
> -----------------------------------------------------------------------
>
>                 Key: HIVE-6716
>                 URL: https://issues.apache.org/jira/browse/HIVE-6716
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.13.0, 0.14.0
>            Reporter: Prasanth J
>            Assignee: Prasanth J
>              Labels: orcfile
>         Attachments: HIVE-6716.1.patch
>
>
> ORCStruct should return null when object passed to getStructFieldsDataAsList(Object obj) is null.
> {code}
> public List<Object> getStructFieldsDataAsList(Object object) {
>       OrcStruct struct = (OrcStruct) object;
>       List<Object> result = new ArrayList<Object>(struct.fields.length);
> {code}
> In the above code struct.fields will throw NPE if struct is NULL.



--
This message was sent by Atlassian JIRA
(v6.2#6252)