You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/15 11:38:16 UTC
[GitHub] [apisix] spacewander opened a new pull request #5068: feat: allow injecting logic to APISIX's method
spacewander opened a new pull request #5068:
URL: https://github.com/apache/apisix/pull/5068
See https://github.com/apache/apisix/discussions/5029
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5068: feat: allow injecting logic to APISIX's method
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5068:
URL: https://github.com/apache/apisix/pull/5068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5068: feat: allow injecting logic to APISIX's method
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5068:
URL: https://github.com/apache/apisix/pull/5068#discussion_r709682674
##########
File path: docs/en/latest/plugin-develop.md
##########
@@ -69,6 +69,21 @@ apisix:
Now using `require "apisix.plugins.3rd-party"` will load your plugin, just like `require "apisix.plugins.jwt-auth"` will load the `jwt-auth` plugin.
+Sometimes you may want to override a method instead of a whole file. In this case, you can configure `lua_module_hook` in `conf/config.yaml`
+to introduce your hook.
+
+Assumed your configuration is:
+
+```yaml
+apisix:
+ ...
+ extra_lua_path: "/path/to/example/?.lua"
+ lua_module_hook: "my_hook"
+```
+
+The `example/my_hook.lua` will be loaded when APISIX starts, and you can use this hook to replace a method in APISIX.
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5068: feat: allow injecting logic to APISIX's method
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #5068:
URL: https://github.com/apache/apisix/pull/5068#discussion_r709677928
##########
File path: docs/en/latest/plugin-develop.md
##########
@@ -69,6 +69,21 @@ apisix:
Now using `require "apisix.plugins.3rd-party"` will load your plugin, just like `require "apisix.plugins.jwt-auth"` will load the `jwt-auth` plugin.
+Sometimes you may want to override a method instead of a whole file. In this case, you can configure `lua_module_hook` in `conf/config.yaml`
+to introduce your hook.
+
+Assumed your configuration is:
+
+```yaml
+apisix:
+ ...
+ extra_lua_path: "/path/to/example/?.lua"
+ lua_module_hook: "my_hook"
+```
+
+The `example/my_hook.lua` will be loaded when APISIX starts, and you can use this hook to replace a method in APISIX.
Review comment:
Maybe refer to the `example/my_hook.lua`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] griffenliu commented on pull request #5068: feat: allow injecting logic to APISIX's method
Posted by GitBox <gi...@apache.org>.
griffenliu commented on pull request #5068:
URL: https://github.com/apache/apisix/pull/5068#issuecomment-939217954
good job!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org