You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by rm...@apache.org on 2016/03/18 18:01:08 UTC
incubator-ranger git commit: RANGER-878: coverity-scan fix- wrong
null check
Repository: incubator-ranger
Updated Branches:
refs/heads/master 4b6068c5b -> a4c3beb71
RANGER-878: coverity-scan fix- wrong null check
Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/a4c3beb7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/a4c3beb7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/a4c3beb7
Branch: refs/heads/master
Commit: a4c3beb7137013f7d5c338b17e3e465cc4a20031
Parents: 4b6068c
Author: rmani <rm...@hortonworks.com>
Authored: Fri Mar 18 10:00:42 2016 -0700
Committer: rmani <rm...@hortonworks.com>
Committed: Fri Mar 18 10:00:42 2016 -0700
----------------------------------------------------------------------
.../java/org/apache/ranger/services/hive/client/HiveClient.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/a4c3beb7/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java
----------------------------------------------------------------------
diff --git a/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java b/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java
index 67e47b9..e38c26c 100644
--- a/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java
+++ b/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java
@@ -37,6 +37,7 @@ import java.util.Properties;
import javax.security.auth.Subject;
+import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.io.FilenameUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -575,11 +576,11 @@ public class HiveClient extends BaseClient implements Closeable {
} catch (Exception e) {
e.printStackTrace();
}
- if (dbList != null && dbList.size() == 0) {
+ if (CollectionUtils.isEmpty(dbList)) {
System.out.println("No database found with db filter [" + args[1] + "]") ;
}
else {
- if (dbList != null && dbList.size() == 0) {
+ if (CollectionUtils.isNotEmpty(dbList)) {
for (String str : dbList ) {
System.out.println("database: " + str ) ;
}