You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Kamil Bregula (Jira)" <ji...@apache.org> on 2020/01/13 17:45:00 UTC
[jira] [Comment Edited] (AIRFLOW-6530) Allow for custom Statsd
client
[ https://issues.apache.org/jira/browse/AIRFLOW-6530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014516#comment-17014516 ]
Kamil Bregula edited comment on AIRFLOW-6530 at 1/13/20 5:44 PM:
-----------------------------------------------------------------
PR is the best place to discuss code. If you don't have PR yer, you can do PR with [WIP] label in title.
was (Author: kamil.bregula):
PR is the best place to discuss code. If you don't have PR now you can do PR with [WIP] label in title.
> Allow for custom Statsd client
> ------------------------------
>
> Key: AIRFLOW-6530
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6530
> Project: Apache Airflow
> Issue Type: New Feature
> Components: scheduler, webserver
> Affects Versions: 1.10.7
> Reporter: Usman Arshad
> Assignee: Usman Arshad
> Priority: Major
> Labels: features
> Fix For: 1.10.8
>
>
> We are currently using Airflow at Skyscanner and we have a custom implementation of Statsd which offers features which wires in nicely into our metrics platform/tooling.
> I'm quite sure that other companies who are using Airflow would also find great benefit in being able to utilise their own custom Statsd client, therefore i am proposing this addition.
>
> The proposed solution looks something along the lines of changing this:
> {code:java}
> statsd = StatsClient(
> host=conf.get('scheduler', 'statsd_host'),
> port=conf.getint('scheduler', 'statsd_port'),
> prefix=conf.get('scheduler', 'statsd_prefix'))
> {code}
> Into
> {code:java}
> statsd = conf.get('STATSD_CLIENT') or StatsClient(
> host=conf.get('scheduler', 'statsd_host'),
> port=conf.getint('scheduler', 'statsd_port'),
> prefix=conf.get('scheduler', 'statsd_prefix'))
> {code}
> Note: Psuedocode, not actual code
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)