You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by vboginskii <gi...@git.apache.org> on 2017/01/31 09:34:06 UTC

[GitHub] zeppelin pull request #1962: [ZEPPELIN-2014] Jetty Directory Listing on app,...

GitHub user vboginskii opened a pull request:

    https://github.com/apache/zeppelin/pull/1962

    [ZEPPELIN-2014] Jetty Directory Listing on app, assets, components, and scripts

    ### What is this PR for?
    Added property for enable/disable public access to directories on server from Web
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2014
    
    ### How should this be tested?
    Run application and try get list of files in app directory from web.
    You will see a response with the code 403. Previously, we saw all files in the directory.
    Change property "zeppelin.server.default.dir.allowed" to true and restart server.
    Try again, all files should be visible.
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vboginskii/zeppelin ZEPPELIN-2014

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1962
    
----
commit f5d09f07bb67836a97132bedd4d03b5ea4ad3890
Author: Viktor Boginskii <vi...@epam.com>
Date:   2017-01-30T17:15:27Z

    [ZEPPELIN-2014] Added property for control public access to directories on server.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1962: [ZEPPELIN-2014] Jetty Directory Listing on app,...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1962


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1962: [ZEPPELIN-2014] Jetty Directory Listing on app, assets...

Posted by vboginskii <gi...@git.apache.org>.

Github user vboginskii commented on the issue:

    https://github.com/apache/zeppelin/pull/1962
  
    Build failed because some tests failed:
    
    Tests in error: 
    
    InterpreterRestApiTest.testRestartInterpreterPerNote:303 NullPointer
    For this test already exist task: https://issues.apache.org/jira/browse/ZEPPELIN-1856  
    
    ParagraphActionsIT.testClearOutputButton:274->AbstractZeppelinIT.waitForParagraph:68->AbstractZeppelinIT.pollingWait:94 � Timeout
    Task for this test:	https://issues.apache.org/jira/browse/ZEPPELIN-1073 
    
    ZeppelinIT.testSparkInterpreterDependencyLoading:234->AbstractZeppelinIT.waitForParagraph:68->AbstractZeppelinIT.pollingWait:94 � Timeout
    And for this test: https://issues.apache.org/jira/browse/ZEPPELIN-1797
    	
    During last build all tests passed, but build failed because "The job exceeded the maximum time limit for jobs, and has been terminated."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1962: [ZEPPELIN-2014] Jetty Directory Listing on app, assets...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1962
  
    @vboginskii Thanks for the contribution. LGTM and merge to master if no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1962: [ZEPPELIN-2014] Jetty Directory Listing on app, assets...

Posted by astroshim <gi...@git.apache.org>.

Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1962
  
    Tested and working expectably.
    Thank you for contributing but Could you make the CI as green?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---