You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "hansva (via GitHub)" <gi...@apache.org> on 2024/09/02 06:16:31 UTC
Re: [PR] save pipeline after unit test is detached. fixes #4247 (hop)
hansva commented on code in PR #4250:
URL: https://github.com/apache/hop/pull/4250#discussion_r1740375060
##########
plugins/misc/testing/src/main/java/org/apache/hop/testing/gui/TestingGuiPlugin.java:
##########
@@ -848,9 +856,24 @@ public void detachUnitTest() {
pipelineGraph.getVariables().setVariable(DataSetConst.VAR_RUN_UNIT_TEST, "N");
pipelineGraph.getVariables().setVariable(DataSetConst.VAR_UNIT_TEST_NAME, null);
+ MetadataManager<PipelineUnitTest> manager =
+ new MetadataManager<>(
+ hopGui.getVariables(),
+ hopGui.getMetadataProvider(),
+ PipelineUnitTest.class,
+ hopGui.getShell());
+ if (manager.editMetadata(unitTest.getName())) {
+ // Activate the test
+ refreshUnitTestsList();
+ // selectUnitTest(pipelineMeta, unitTest);
Review Comment:
remove this line if not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org