You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2019/10/17 18:09:59 UTC
Review Request 71635: Plugin capability/compatibility model
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71635/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-2625
https://issues.apache.org/jira/browse/RANGER-2625
Repository: ranger
Description
-------
When features and capabilities are added to Ranger, it is possible to get into situation where users/admins may write policies using new capabilities that are not available in the deployed plugins. As a first step towards understanding and ensuring version compatibility between ranger-admin and plugins, it is desirable that plugin reports features/capabilities that it supports to ranger-admin periodically, and ranger-admin persists this information for review.
This patch contains enhancements for plugins to report their capabilities when they download policies/tags/roles and for ranger-admin to persist them for each reporting plugin.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java f564ba52e
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 4bd374e87
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPluginCapability.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java d612e7ff6
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestRangerPluginCapability.java PRE-CREATION
agents-common/src/test/resources/policyengine/plugin/test_plugin_capability.json PRE-CREATION
knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java 53be9c2df
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java e17571f3c
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 66a57289f
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 3156e482e
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 5b3803324
security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 51f33db09
security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java dce3b0b69
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java a7e19bf03
security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java 402f1ce2c
Diff: https://reviews.apache.org/r/71635/diff/1/
Testing
-------
Developed unit tests and ran them successfully.
Thanks,
Abhay Kulkarni
Re: Review Request 71635: Plugin capability/compatibility model
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71635/#review218277
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 17, 2019, 7:13 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71635/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2019, 7:13 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-2625
> https://issues.apache.org/jira/browse/RANGER-2625
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When features and capabilities are added to Ranger, it is possible to get into situation where users/admins may write policies using new capabilities that are not available in the deployed plugins. As a first step towards understanding and ensuring version compatibility between ranger-admin and plugins, it is desirable that plugin reports features/capabilities that it supports to ranger-admin periodically, and ranger-admin persists this information for review.
>
> This patch contains enhancements for plugins to report their capabilities when they download policies/tags/roles and for ranger-admin to persist them for each reporting plugin.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java f564ba52e
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 4bd374e87
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPluginCapability.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java d612e7ff6
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestRangerPluginCapability.java PRE-CREATION
> agents-common/src/test/resources/policyengine/plugin/test_plugin_capability.json PRE-CREATION
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java 53be9c2df
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java e17571f3c
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 66a57289f
> security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 3156e482e
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 5b3803324
> security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 51f33db09
> security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java dce3b0b69
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java a7e19bf03
> security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java 402f1ce2c
>
>
> Diff: https://reviews.apache.org/r/71635/diff/2/
>
>
> Testing
> -------
>
> Developed unit tests and ran them successfully.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 71635: Plugin capability/compatibility model
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71635/
-----------------------------------------------------------
(Updated Oct. 17, 2019, 7:13 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Addressed review comment
Bugs: RANGER-2625
https://issues.apache.org/jira/browse/RANGER-2625
Repository: ranger
Description
-------
When features and capabilities are added to Ranger, it is possible to get into situation where users/admins may write policies using new capabilities that are not available in the deployed plugins. As a first step towards understanding and ensuring version compatibility between ranger-admin and plugins, it is desirable that plugin reports features/capabilities that it supports to ranger-admin periodically, and ranger-admin persists this information for review.
This patch contains enhancements for plugins to report their capabilities when they download policies/tags/roles and for ranger-admin to persist them for each reporting plugin.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java f564ba52e
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 4bd374e87
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPluginCapability.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java d612e7ff6
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestRangerPluginCapability.java PRE-CREATION
agents-common/src/test/resources/policyengine/plugin/test_plugin_capability.json PRE-CREATION
knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java 53be9c2df
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java e17571f3c
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 66a57289f
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 3156e482e
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 5b3803324
security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 51f33db09
security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java dce3b0b69
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java a7e19bf03
security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java 402f1ce2c
Diff: https://reviews.apache.org/r/71635/diff/2/
Changes: https://reviews.apache.org/r/71635/diff/1-2/
Testing
-------
Developed unit tests and ran them successfully.
Thanks,
Abhay Kulkarni
Re: Review Request 71635: Plugin capability/compatibility model
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71635/#review218273
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPluginCapability.java
Lines 72 (patched)
<https://reviews.apache.org/r/71635/#comment305918>
'current' suggests the build-time, which is not the case. Perhaps move the details to a static/private method - computeBaseCapabilities(), and assign to 'baseRangerCapabilities' (and make this static-final).
- Madhan Neethiraj
On Oct. 17, 2019, 6:09 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71635/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2019, 6:09 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-2625
> https://issues.apache.org/jira/browse/RANGER-2625
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When features and capabilities are added to Ranger, it is possible to get into situation where users/admins may write policies using new capabilities that are not available in the deployed plugins. As a first step towards understanding and ensuring version compatibility between ranger-admin and plugins, it is desirable that plugin reports features/capabilities that it supports to ranger-admin periodically, and ranger-admin persists this information for review.
>
> This patch contains enhancements for plugins to report their capabilities when they download policies/tags/roles and for ranger-admin to persist them for each reporting plugin.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java f564ba52e
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 4bd374e87
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPluginCapability.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java d612e7ff6
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestRangerPluginCapability.java PRE-CREATION
> agents-common/src/test/resources/policyengine/plugin/test_plugin_capability.json PRE-CREATION
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java 53be9c2df
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java e17571f3c
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 66a57289f
> security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 3156e482e
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 5b3803324
> security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 51f33db09
> security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java dce3b0b69
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java a7e19bf03
> security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java 402f1ce2c
>
>
> Diff: https://reviews.apache.org/r/71635/diff/1/
>
>
> Testing
> -------
>
> Developed unit tests and ran them successfully.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>