You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Dale Newfield (JIRA)" <ji...@apache.org> on 2007/12/19 06:14:33 UTC

[jira] Commented: (WW-2383) option transfer select .ftl is brittle

    [ https://issues.apache.org/struts/browse/WW-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42832 ] 

Dale Newfield commented on WW-2383:
-----------------------------------

Discussed on the user list:  http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--to14344098.html#a14344098

The bad patch this backs out was suggested on that thread and discussed on the dev list:  http://www.nabble.com/svn-commit-3A-r604737----struts-struts2-trunk-core-src-main-resources-template-simple-optiontransferselect.ftl-to14367675.html

> option transfer select .ftl is brittle
> --------------------------------------
>
>                 Key: WW-2383
>                 URL: https://issues.apache.org/struts/browse/WW-2383
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11, 2.1.0
>            Reporter: Dale Newfield
>            Priority: Minor
>         Attachments: optiontransferselect.patch
>
>
> This type of patch probably should be applied in a number of places, but this bug is just for one of them.
> I had an optiontransferselect tag that had an entry that happened to have "null" as it's label.  This caused freemarker to throw an exception (that got displayed textually in the generated page.  This exception meant that the output was no longer well formed, which caused sitemesh to crash with an ugly error message.
> In freemarker, while "null" is a valid value, apparently it's illegal to store that in a variable, so the assign tag is where this failed.
> The fix is very simple:  provide a default value of "" just in case the attribute lookup returns null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.