You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Paul Foxworthy (JIRA)" <ji...@apache.org> on 2016/11/24 00:33:58 UTC

[jira] [Commented] (OFBIZ-7263) Price rule created with product specific quantity condition not applied to the order when adding the product to cart with less quantity than mentioned in condition

    [ https://issues.apache.org/jira/browse/OFBIZ-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691777#comment-15691777 ] 

Paul Foxworthy commented on OFBIZ-7263:
---------------------------------------

Hi Aditi,

Good work, I think you've found a bug.

Compare the code in ShoppingCartServices with the updateApprovedOrderItems method in OrderServices:

https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java?r=1768192#to3712

in particular, lines 3712 and 3740.

If I understand the code correctly, isModified should say there has been human intervention to set a one-off price for this order that is different to the standard rules. Adjusting a quantity should *not* change the value of isModified.

Can you create a patch for your change?

Thanks

Paul



> Price rule created with product specific quantity condition not applied to the order when adding the product to cart with less quantity than mentioned in condition
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7263
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7263
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Aditi Patidar
>            Assignee: Aditi Patidar
>
> Steps to regenerate the issue:
> 1. Create a price rule.
> 2. Add a condition, select input 'Quantity', operator 'Is' and add the value '2' or any quantity more than 1.
> 3. Add an action, select action type 'Flat Amount Override'  and add it's value.  
> 4. Create a sale order:
>     i. Add product with quantity one to the order.
>     ii. Update the quantity to 2 or to the value entered in condition for quantity in price rule.
>    iii. Recalculate the order.
> Expected result: Unit price should override to the amount added in action.
> Actual result: It's not getting overridden to the amount added in action.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)