You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by oknet <gi...@git.apache.org> on 2017/01/18 13:54:12 UTC

[GitHub] trafficserver pull request #1334: Do not reschedule the periodic inactive_ev...

GitHub user oknet opened a pull request:

    https://github.com/apache/trafficserver/pull/1334

    Do not reschedule the periodic inactive_event and cancel it after signal timeout event to SM

    this resolve issue 1333

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oknet/trafficserver i1333

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1334
    
----
commit bf4fc46fa7030abf25e46f03973f4a037cc642e5
Author: Oknet Xu <xu...@skyguard.com.cn>
Date:   2017-01-18T13:50:57Z

    Do not reschedule the periodic inactive_event and cancel it after signal timeout event to SM

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:

    https://github.com/apache/trafficserver/pull/1334
  
    The inactive_event is a periodic event that is create by eventProcessor.schedule_every().
    We should not reschedule it by schedule_in().
    
    We cancelled it by call_event->cancel() even it is rescheduled by schedule_in() in process_timeout().
    
    It cause a crash on process_close() due to we cancel a event but not set the inactive_event to NULL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/1334
  
    Merged this to the 7.1.x branch as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1334
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1345/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1334
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1238/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:

    https://github.com/apache/trafficserver/pull/1334
  
    Link it to https://issues.apache.org/jira/browse/TS-3235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1334: Do not reschedule the periodic inactive_ev...

Posted by oknet <gi...@git.apache.org>.
Github user oknet closed the pull request at:

    https://github.com/apache/trafficserver/pull/1334


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---