You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/02 14:17:16 UTC
[GitHub] [beam] Abacn commented on a diff in pull request #24274: Support Avro GenericRecord as a valid format for StorageWrite API on BigQueryIO
Abacn commented on code in PR #24274:
URL: https://github.com/apache/beam/pull/24274#discussion_r1038186826
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java:
##########
@@ -265,6 +266,7 @@ public abstract static class Builder {
.put(SqlTypes.DATETIME.getIdentifier(), StandardSQLTypeName.DATETIME)
.put("SqlTimeWithLocalTzType", StandardSQLTypeName.TIME)
.put("Enum", StandardSQLTypeName.STRING)
+ .put(MicrosInstant.IDENTIFIER, StandardSQLTypeName.TIMESTAMP)
Review Comment:
fyi Support of Micros_instant in AvroUtils is about to rolled back due to a breaking change (#24489). By now MicrosInstant logical type (and `java.time.Instant`) support is incomplete throughout the code base. Sorry for inconvenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org