You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2015/11/26 16:21:38 UTC
Review Request 40752: Fixed FetcherCacheTest test fixture
initialization ordering issue.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40752/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Till Toenshoff.
Bugs: MESOS-3755
https://issues.apache.org/jira/browse/MESOS-3755
Repository: mesos
Description
-------
Fixed FetcherCacheTest test fixture initialization ordering issue.
Diffs
-----
src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309
Diff: https://reviews.apache.org/r/40752/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 40752: Fixed FetcherCacheTest test fixture
initialization ordering issue.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40752/
-----------------------------------------------------------
(Updated Nov. 26, 2015, 9:59 p.m.)
Review request for mesos, Bernd Mathiske and Till Toenshoff.
Changes
-------
Address issues.
Bugs: MESOS-3755
https://issues.apache.org/jira/browse/MESOS-3755
Repository: mesos
Description
-------
Fixed FetcherCacheTest test fixture initialization ordering issue.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309
Diff: https://reviews.apache.org/r/40752/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 40752: Fixed FetcherCacheTest test fixture
initialization ordering issue.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40752/#review108155
-----------------------------------------------------------
Ship it!
src/tests/fetcher_cache_tests.cpp (line 280)
<https://reviews.apache.org/r/40752/#comment167502>
Lets remove this comment, it does not help, I feel.
- Till Toenshoff
On Nov. 26, 2015, 3:21 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40752/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 3:21 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
>
>
> Bugs: MESOS-3755
> https://issues.apache.org/jira/browse/MESOS-3755
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed FetcherCacheTest test fixture initialization ordering issue.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309
>
> Diff: https://reviews.apache.org/r/40752/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40752: Fixed FetcherCacheTest test fixture
initialization ordering issue.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40752/#review108149
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Nov. 26, 2015, 7:21 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40752/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 7:21 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
>
>
> Bugs: MESOS-3755
> https://issues.apache.org/jira/browse/MESOS-3755
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed FetcherCacheTest test fixture initialization ordering issue.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309
>
> Diff: https://reviews.apache.org/r/40752/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>