You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Ivan Dubrov (JIRA)" <de...@tapestry.apache.org> on 2007/09/25 06:36:51 UTC

[jira] Created: (TAPESTRY-1778) Allow extending the PageTester with extra modules for better integration with tapestry-spring

Allow extending the PageTester with extra modules for better integration with tapestry-spring
---------------------------------------------------------------------------------------------

                 Key: TAPESTRY-1778
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1778
             Project: Tapestry
          Issue Type: New Feature
          Components: tapestry-core, tapestry-spring
    Affects Versions: 5.0.5
            Reporter: Ivan Dubrov
         Attachments: pagetester.patch

The problem is that when PageTester creates the registry it does not adds SpringModuleDef to the list of modules and all Spring services are unavailable because of this. Extending the PageTester is not possible as well, so you cannot extend it and provide additional module (like the TapestrySpringFilter does), so you have to copy-paste the complete PageTester and add a single line to include SpringModuleDef module to the list.

I suggest adding the method similar to the TapestryFilter#provideExtraModuleDefs() to the PageTester.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-1778) Allow extending the PageTester with extra modules for better integration with tapestry-spring

Posted by "angerclown (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567161#action_12567161 ] 

angerclown commented on TAPESTRY-1778:
--------------------------------------

Probably a good idea to have provideExtraModuleDefs() in PageTester, regardless of whether you need Spring or not.

I think that there should be also a SpringPageTester subclass that already does the work needed for provideExtraModuleDefs(). I am not exactly sure how you would pass in the data you need to providedExtraModuleDefs. For Spring, you would need a list of file paths or Resource objects. Maybe the easiest, if somewhat inelegant way, would be to just read a system parameter and parse the String.


> Allow extending the PageTester with extra modules for better integration with tapestry-spring
> ---------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-1778
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1778
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: tapestry-core, tapestry-spring
>    Affects Versions: 5.0.5
>            Reporter: Ivan Dubrov
>         Attachments: pagetester.patch
>
>
> The problem is that when PageTester creates the registry it does not adds SpringModuleDef to the list of modules and all Spring services are unavailable because of this. Extending the PageTester is not possible as well, so you cannot extend it and provide additional module (like the TapestrySpringFilter does), so you have to copy-paste the complete PageTester and add a single line to include SpringModuleDef module to the list.
> I suggest adding the method similar to the TapestryFilter#provideExtraModuleDefs() to the PageTester.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-1778) Allow extending the PageTester with extra modules for better integration with tapestry-spring

Posted by "Ivan Dubrov (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Dubrov updated TAPESTRY-1778:
----------------------------------

    Attachment: pagetester.patch

Simple fix.

> Allow extending the PageTester with extra modules for better integration with tapestry-spring
> ---------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-1778
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1778
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: tapestry-core, tapestry-spring
>    Affects Versions: 5.0.5
>            Reporter: Ivan Dubrov
>         Attachments: pagetester.patch
>
>
> The problem is that when PageTester creates the registry it does not adds SpringModuleDef to the list of modules and all Spring services are unavailable because of this. Extending the PageTester is not possible as well, so you cannot extend it and provide additional module (like the TapestrySpringFilter does), so you have to copy-paste the complete PageTester and add a single line to include SpringModuleDef module to the list.
> I suggest adding the method similar to the TapestryFilter#provideExtraModuleDefs() to the PageTester.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Closed: (TAPESTRY-1778) Allow extending the PageTester with extra modules for better integration with tapestry-spring

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAPESTRY-1778.
------------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0.11
         Assignee: Howard M. Lewis Ship

> Allow extending the PageTester with extra modules for better integration with tapestry-spring
> ---------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-1778
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1778
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: tapestry-core, tapestry-spring
>    Affects Versions: 5.0.5
>            Reporter: Ivan Dubrov
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.0.11
>
>         Attachments: pagetester.patch
>
>
> The problem is that when PageTester creates the registry it does not adds SpringModuleDef to the list of modules and all Spring services are unavailable because of this. Extending the PageTester is not possible as well, so you cannot extend it and provide additional module (like the TapestrySpringFilter does), so you have to copy-paste the complete PageTester and add a single line to include SpringModuleDef module to the list.
> I suggest adding the method similar to the TapestryFilter#provideExtraModuleDefs() to the PageTester.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org