You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/10 02:00:48 UTC
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10383: Add some warning log in master
caishunfeng commented on code in PR #10383:
URL: https://github.com/apache/dolphinscheduler/pull/10383#discussion_r894093540
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java:
##########
@@ -157,11 +154,15 @@ public List<TaskPriority> batchDispatch(int fetchTaskNum) throws TaskPriorityQue
}
consumerThreadPoolExecutor.submit(() -> {
- boolean dispatchResult = this.dispatchTask(taskPriority);
- if (!dispatchResult) {
- failedDispatchTasks.add(taskPriority);
+ try {
+ boolean dispatchResult = this.dispatchTask(taskPriority);
+ if (!dispatchResult) {
+ failedDispatchTasks.add(taskPriority);
+ }
+ } finally {
Review Comment:
Is it better to add exception catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org