[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7136: Python: Make Python CI collect most of the unit tests

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7136:
URL: https://github.com/apache/iceberg/pull/7136#discussion_r1142457668


##########
python/Makefile:
##########
@@ -27,7 +27,7 @@ lint:
 
 test:
 	poetry run coverage run --source=pyiceberg/ -m pytest tests/ -m unmarked ${PYTEST_ARGS}
-	poetry run coverage report -m --fail-under=90
+	poetry run coverage report -m --fail-under=88

Review Comment:
   We definitely want to keep this 90, but it's probably more important to at least run the tests and we don't want to blindly add tests just for the sake of making it 90, I will approve the PR, but can you create an Issue tracking that so we take a deeper look at where we can add more tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org