You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/26 13:11:32 UTC
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs
GutoVeronezi commented on a change in pull request #4966:
URL: https://github.com/apache/cloudstack/pull/4966#discussion_r696614342
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4390,13 +4390,18 @@ public VMInstanceVO reConfigureVm(final String vmUuid, final ServiceOffering old
VirtualMachine vm = retrieveVmFromJobOutcome(outcome, vmUuid, "reconfigureVm");
+ Object result = null;
try {
- retrieveResultFromJobOutcomeAndThrowExceptionIfNeeded(outcome);
- } catch (InsufficientCapacityException ex) {
+ result = retrieveResultFromJobOutcomeAndThrowExceptionIfNeeded(outcome);
+
+ if (result == null) {
+ return (VMInstanceVO)vm;
+ }
+ } catch (Exception ex) {
Review comment:
@DaanHoogland makes sense in this case. I made the changes, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org